Changeset 175639 in webkit


Ignore:
Timestamp:
Nov 5, 2014 1:21:58 PM (9 years ago)
Author:
Chris Dumez
Message:

Remove 2 unnecessary virtual functions on InputType
​https://bugs.webkit.org/show_bug.cgi?id=138433

Reviewed by Andreas Kling.

Remove 2 unused virtual functions on InputType:

  • valueAttributeChanged()
  • updateClearButtonVisibility()

No new tests, no behavior change.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::updateClearButtonVisibility): Deleted.

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::valueAttributeChanged): Deleted.
(WebCore::InputType::updateClearButtonVisibility): Deleted.

  • html/InputType.h:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r175627 r175639  
     12014-11-05  Chris Dumez  <cdumez@apple.com>
     2
     3        Remove 2 unnecessary virtual functions on InputType
     4        https://bugs.webkit.org/show_bug.cgi?id=138433
     5
     6        Reviewed by Andreas Kling.
     7
     8        Remove 2 unused virtual functions on InputType:
     9        - valueAttributeChanged()
     10        - updateClearButtonVisibility()
     11
     12        No new tests, no behavior change.
     13
     14        * html/HTMLInputElement.cpp:
     15        (WebCore::HTMLInputElement::parseAttribute):
     16        (WebCore::HTMLInputElement::updateClearButtonVisibility): Deleted.
     17        * html/HTMLInputElement.h:
     18        * html/InputType.cpp:
     19        (WebCore::InputType::valueAttributeChanged): Deleted.
     20        (WebCore::InputType::updateClearButtonVisibility): Deleted.
     21        * html/InputType.h:
     22
    1232014-11-05  Chris Dumez  <cdumez@apple.com>
    224

  • trunk/Source/WebCore/html/HTMLInputElement.cpp

    r175622 r175639  
    636636        setNeedsValidityCheck();
    637637        m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress;
    638         m_inputType->valueAttributeChanged();
    639638    } else if (name == checkedAttr) {
    640639        // Another radio button in the same group might be checked by state
    … …  
    13821381}
    13831382
    1384 void HTMLInputElement::updateClearButtonVisibility()
    1385 {
    1386     m_inputType->updateClearButtonVisibility();
    1387 }
    1388 
    13891383void HTMLInputElement::documentDidResumeFromPageCache()
    13901384{

  • trunk/Source/WebCore/html/HTMLInputElement.h

    r175622 r175639  
    260260    void onSearch();
    261261
    262     void updateClearButtonVisibility();
    263 
    264262    virtual bool willRespondToMouseClickEvents() override;
    265263

  • trunk/Source/WebCore/html/InputType.cpp

    r174225 r175639  
    920920}
    921921
    922 void InputType::valueAttributeChanged()
    923 {
    924 }
    925 
    926922void InputType::subtreeHasChanged()
    927923{
    … …  
    952948}
    953949#endif
    954 
    955 void InputType::updateClearButtonVisibility()
    956 {
    957 }
    958950
    959951bool InputType::supportsIndeterminateAppearance() const

  • trunk/Source/WebCore/html/InputType.h

    r172817 r175639  
    272272    virtual void readonlyAttributeChanged();
    273273    virtual void requiredAttributeChanged();
    274     virtual void valueAttributeChanged();
    275274    virtual String defaultToolTip() const;
    276     virtual void updateClearButtonVisibility();
    277275
    278276#if ENABLE(DATALIST_ELEMENT)
Note: See TracChangeset for help on using the changeset viewer.