Changeset 175642 in webkit

Timestamp:

Nov 5, 2014 2:50:33 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Specificity not shown for pseudo element styles
​https://bugs.webkit.org/show_bug.cgi?id=138436

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-05
Reviewed by Benjamin Poulain.

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Previously we were skipping the pre-selector <span>s when we were
not getting a listing of matched selector indices, and missing out
on the opportunity to give each selector a specificity. Now, always
loop over selectors if we have them.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Specificity not shown for pseudo element styles
+        https://bugs.webkit.org/show_bug.cgi?id=138436
+
+        Reviewed by Benjamin Poulain.
+
+        * UserInterface/Views/CSSStyleDeclarationSection.js:
+        (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
+        Previously we were skipping the pre-selector <span>s when we were
+        not getting a listing of matched selector indices, and missing out
+        on the opportunity to give each selector a specificity. Now, always
+        loop over selectors if we have them.
+
 2014-11-05  Jonathan Wells  <jonowells@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js

@@ -202 +202 @@
             var selectors = this._style.ownerRule.selectors;
             var matchedSelectorIndices = this._style.ownerRule.matchedSelectorIndices;
-            if (selectors.length && matchedSelectorIndices.length) {
+            var alwaysMatch = !matchedSelectorIndices.length;
+            if (selectors.length) {
                 for (var i = 0; i < selectors.length; ++i) {
-                    appendSelector.call(this, selectors[i], matchedSelectorIndices.contains(i));
+                    appendSelector.call(this, selectors[i], alwaysMatch || matchedSelectorIndices.contains(i));
                     if (i < selectors.length - 1)
                         this._selectorElement.appendChild(document.createTextNode(", "));