Changeset 175688 in webkit
- Timestamp:
- Nov 5, 2014 11:53:01 PM (9 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r175687 r175688 1 2014-11-05 Shivakumar JM <shiva.jm@samsung.com> 2 3 splitText API does not match DOM specification. 4 https://bugs.webkit.org/show_bug.cgi?id=138405 5 6 Reviewed by Chris Dumez. 7 8 * fast/dom/Text/splitText-expected.txt: Added. 9 * fast/dom/Text/splitText.html: Added. 10 * fast/dom/non-numeric-values-numeric-parameters-expected.txt: 11 * fast/dom/script-tests/non-numeric-values-numeric-parameters.js: 12 1 13 2014-11-05 Commit Queue <commit-queue@webkit.org> 2 14 -
trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
r171014 r175688 63 63 PASS nonNumericPolicy('getSelection().getRangeAt(x)') is 'any type allowed' 64 64 PASS nonNumericPolicy('document.styleSheets.item(x)') is 'any type allowed' 65 PASS nonNumericPolicy('document.createTextNode("a").splitText(x)') is 'any type allowed '65 PASS nonNumericPolicy('document.createTextNode("a").splitText(x)') is 'any type allowed (but not omitted)' 66 66 PASS nonNumericPolicy('document.createTreeWalker(document, x, null, false)') is 'any type allowed' 67 67 PASS nonNumericPolicy('document.createEvent("UIEvent").initUIEvent("a", false, false, null, x)') is 'any type allowed' -
trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
r171014 r175688 328 328 // Text 329 329 330 shouldBe("nonNumericPolicy('document.createTextNode(\"a\").splitText(x)')", "'any type allowed '");330 shouldBe("nonNumericPolicy('document.createTextNode(\"a\").splitText(x)')", "'any type allowed (but not omitted)'"); 331 331 332 332 // TimeRanges -
trunk/Source/WebCore/ChangeLog
r175687 r175688 1 2014-11-05 Shivakumar JM <shiva.jm@samsung.com> 2 3 splitText API does not match DOM specification. 4 https://bugs.webkit.org/show_bug.cgi?id=138405 5 6 Reviewed by Chris Dumez. 7 8 Make the offset argument for splitText API as mandatory (and thus throw if it is omitted) and stop throwing if the offset argument is 9 negative (and wraps to a valid index) as per specification: https://w3c.github.io/dom/#interface-text. Also This matches the behavior 10 of both Firefox 33 and Chrome 38. 11 12 Test: fast/dom/Text/splitText.html 13 14 * dom/Text.idl: 15 1 16 2014-11-05 Commit Queue <commit-queue@webkit.org> 2 17 -
trunk/Source/WebCore/dom/Text.idl
r165676 r175688 24 24 // DOM Level 1 25 25 26 [RaisesException] Text splitText( [IsIndex,Default=Undefined] optionalunsigned long offset);26 [RaisesException] Text splitText(unsigned long offset); 27 27 28 28 // Introduced in DOM Level 3:
Note: See TracChangeset
for help on using the changeset viewer.