Changeset 176119 in webkit

Timestamp:

Nov 14, 2014 12:49:55 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

[SOUP] Encode/Decode allowCookies in ResourceRequest
​https://bugs.webkit.org/show_bug.cgi?id=138730

Reviewed by Sergio Villar Senin.

We are not sending this information to the network process, making
cookies always available. Fixes
http/tests/xmlhttprequest/cross-origin-no-authorization.html when
network process is enabled.

• Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/soup/WebCoreArgumentCodersSoup.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Encode/Decode allowCookies in ResourceRequest
+        https://bugs.webkit.org/show_bug.cgi?id=138730
+
+        Reviewed by Sergio Villar Senin.
+
+        We are not sending this information to the network process, making
+        cookies always available. Fixes
+        http/tests/xmlhttprequest/cross-origin-no-authorization.html when
+        network process is enabled.
+
+        * Shared/soup/WebCoreArgumentCodersSoup.cpp:
+        (IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
+        (IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
+
 2014-11-14  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp

@@ -56 +56 @@
 
     encoder << resourceRequest.firstPartyForCookies().string();
+    encoder << resourceRequest.allowCookies();
     encoder.encodeEnum(resourceRequest.priority());
 
@@ -98 +99 @@
         return false;
     resourceRequest.setFirstPartyForCookies(URL(URL(), firstPartyForCookies));
+
+    bool allowCookies;
+    if (!decoder.decode(allowCookies))
+        return false;
+    resourceRequest.setAllowCookies(allowCookies);
 
     ResourceLoadPriority priority;