Changeset 17615 in webkit


Ignore:
Timestamp:
Nov 6, 2006 4:54:30 AM (17 years ago)
Author:
bdash
Message:

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Update DOMNode::toString to always use className rather than preferring nodeName.

  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::toString): Match the format returned by valueOf.

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Updated test results for change from nodeName to className in DOMNode::toString.

  • fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/replace-first-child-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/input-appearance-preventDefault-expected.checksum:
  • fast/forms/input-appearance-preventDefault-expected.png:
  • fast/forms/input-appearance-preventDefault-expected.txt:
  • fast/loader/loadInProgress-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.checksum:
  • fast/tokenizer/external-script-document-write-expected.png:
  • fast/tokenizer/external-script-document-write-expected.txt:
  • traversal/stay-within-root-expected.checksum:
  • traversal/stay-within-root-expected.png:
  • traversal/stay-within-root-expected.txt:
Location:
trunk
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r17611 r17615  
     12006-11-06  Mark Rowe  <bdash@webkit.org>
     2
     3        Reviewed by Maciej.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=11526
     6        Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
     7
     8        Updated test results for change from nodeName to className in DOMNode::toString.
     9
     10        * fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
     11        * fast/dom/prototype-chain-expected.txt:
     12        * fast/dom/replace-first-child-expected.txt:
     13        * fast/events/mouseclick-target-and-positioning-expected.txt:
     14        * fast/forms/input-appearance-preventDefault-expected.checksum:
     15        * fast/forms/input-appearance-preventDefault-expected.png:
     16        * fast/forms/input-appearance-preventDefault-expected.txt:
     17        * fast/loader/loadInProgress-expected.txt:
     18        * fast/tokenizer/external-script-document-write-expected.checksum:
     19        * fast/tokenizer/external-script-document-write-expected.png:
     20        * fast/tokenizer/external-script-document-write-expected.txt:
     21        * traversal/stay-within-root-expected.checksum:
     22        * traversal/stay-within-root-expected.png:
     23        * traversal/stay-within-root-expected.txt:
     24
    1252006-11-06  Alexey Proskuryakov  <ap@webkit.org>
    226

  • trunk/LayoutTests/fast/dom/HTMLMetaElement/meta-attributes-expected.txt

    r14413 r17615  
    11You should see 5 lines with "SUCCESS" below:
    2 SUCCESS (value: "[object META]")
     2FAILURE: expected "[object META]", actual "[object HTMLMetaElement]"
    33
    44SUCCESS (value: "foo")

  • trunk/LayoutTests/fast/dom/prototype-chain-expected.txt

    r14463 r17615  
    1919[object HTMLDocument]
    2020
    21 ----- [object DIV] (8 prototypes) -----
     21----- [object HTMLDivElement] (8 prototypes) -----
    2222
    2323[object Object]

  • trunk/LayoutTests/fast/dom/replace-first-child-expected.txt

    r12344 r17615  
    11This tests for a bug in replaceChild where it would fail to replace an element if it was the first child of its container. See bug 6782 for details. If the test is successful you will see an object description below, and if it fails you will see "null".
    22
    3 [object DIV]
     3[object HTMLDivElement]
    44

  • trunk/LayoutTests/fast/events/mouseclick-target-and-positioning-expected.txt

    r17562 r17615  
    33click inside the red box:
    44[]
    5 PASS: event target should be [object SPAN] and is
     5PASS: event target should be [object HTMLElement] and is
    66PASS: event.pageX should be 175 and is
    77PASS: event.pageY should be 105 and is

  • trunk/LayoutTests/fast/forms/input-appearance-preventDefault-expected.checksum

    r14936 r17615  
    1 a9fb25b7dcabbe0dcfd6df906d7a32df
     14fc2dfc07ffba17b0ba75af3f25c9fe1

  • trunk/LayoutTests/fast/forms/input-appearance-preventDefault-expected.txt

    r14684 r17615  
    1717    RenderText {#text} at (1,0) size 129x13
    1818      text run at (1,0) width 129: "No caret should be here"
    19 layer at (10,70) size 240x36
    20   RenderBlock (positioned) {DIV} at (10,70) size 240x36
     19layer at (10,70) size 323x36
     20  RenderBlock (positioned) {DIV} at (10,70) size 323x36
    2121    RenderBR {BR} at (0,0) size 0x18
    22     RenderText {#text} at (0,18) size 240x18
    23       text run at (0,18) width 240: "mousedown on target [object INPUT]"
     22    RenderText {#text} at (0,18) size 323x18
     23      text run at (0,18) width 323: "mousedown on target [object HTMLInputElement]"

  • trunk/LayoutTests/fast/loader/loadInProgress-expected.txt

    r13851 r17615  
    1 ALERT: Test passed: [object FORM]
     1ALERT: Test passed: [object HTMLFormElement]
    22
    33

  • trunk/LayoutTests/fast/tokenizer/external-script-document-write-expected.checksum

    r11995 r17615  
    1 51a6e47d52b6df9301877707d6d1f4ac
     17e57f97082d3ae6aba1a3443a8cca169

  • trunk/LayoutTests/fast/tokenizer/external-script-document-write-expected.txt

    r14684 r17615  
    55    RenderBody {BODY} at (8,8) size 784x18
    66      RenderInline {SPAN} at (0,0) size 0x0
    7       RenderText {#text} at (0,0) size 239x18
    8         text run at (0,0) width 239: "This should be a span: [object SPAN]"
     7      RenderText {#text} at (0,0) size 295x18
     8        text run at (0,0) width 295: "This should be a span: [object HTMLElement]"

  • trunk/LayoutTests/traversal/stay-within-root-expected.checksum

    r15232 r17615  
    1 6ac3a1ffc86df24c99698a832aa89249
     16be147d47c579f68ea789faf193a0ffe

  • trunk/LayoutTests/traversal/stay-within-root-expected.txt

    r15009 r17615  
    1919        RenderListItem {LI} at (40,18) size 744x18
    2020          RenderListMarker at (-20,0) size 16x18
    21           RenderText {#text} at (0,0) size 81x18
    22             text run at (0,0) width 81: "[object DIV]"
     21          RenderText {#text} at (0,0) size 174x18
     22            text run at (0,0) width 174: "[object HTMLDivElement]"
    2323        RenderListItem {LI} at (40,36) size 744x18
    2424          RenderListMarker at (-20,0) size 16x18
    25           RenderText {#text} at (0,0) size 81x18
    26             text run at (0,0) width 81: "[object DIV]"
     25          RenderText {#text} at (0,0) size 174x18
     26            text run at (0,0) width 174: "[object HTMLDivElement]"
    2727        RenderListItem {LI} at (40,54) size 744x18
    2828          RenderListMarker at (-20,0) size 16x18
    29           RenderText {#text} at (0,0) size 81x18
    30             text run at (0,0) width 81: "[object DIV]"
     29          RenderText {#text} at (0,0) size 174x18
     30            text run at (0,0) width 174: "[object HTMLDivElement]"
    3131        RenderListItem {LI} at (40,72) size 744x18
    3232          RenderListMarker at (-20,0) size 16x18
    … …  
    4747        RenderListItem {LI} at (40,144) size 744x18
    4848          RenderListMarker at (-20,0) size 16x18
    49           RenderText {#text} at (0,0) size 81x18
    50             text run at (0,0) width 81: "[object DIV]"
     49          RenderText {#text} at (0,0) size 174x18
     50            text run at (0,0) width 174: "[object HTMLDivElement]"
    5151        RenderListItem {LI} at (40,162) size 744x18
    5252          RenderListMarker at (-28,0) size 24x18
    53           RenderText {#text} at (0,0) size 81x18
    54             text run at (0,0) width 81: "[object DIV]"
     53          RenderText {#text} at (0,0) size 174x18
     54            text run at (0,0) width 174: "[object HTMLDivElement]"
    5555        RenderListItem {LI} at (40,180) size 744x18
    5656          RenderListMarker at (-28,0) size 24x18

  • trunk/WebCore/ChangeLog

    r17612 r17615  
     12006-11-06  Mark Rowe  <bdash@webkit.org>
     2
     3        Reviewed by Maciej.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=11526
     6        Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
     7
     8        Update DOMNode::toString to always use className rather than preferring nodeName.
     9
     10        * bindings/js/kjs_dom.cpp:
     11        (KJS::DOMNode::toString): Match the format returned by valueOf.
     12
    1132006-11-06  Oliver Hunt  <oliver@apple.com>
    214

  • trunk/WebCore/bindings/js/kjs_dom.cpp

    r16353 r17615  
    275275}
    276276
    277 UString DOMNode::toString(ExecState* ) const
    278 {
    279   if (!m_impl)
    280     return "null";
    281   return "[object " + (m_impl->isElementNode() ? UString(m_impl->nodeName()) : className()) + "]";
     277UString DOMNode::toString(ExecState*) const
     278{
     279    if (!m_impl)
     280        return "null";
     281    return "[object " + className() + "]";
    282282}
    283283
Note: See TracChangeset for help on using the changeset viewer.