Changeset 176160 in webkit


Ignore:
Timestamp:
Nov 15, 2014 11:34:26 PM (9 years ago)
Author:
jdiggs@igalia.com
Message:

AX: [ATK] Lists with selectable children should have ATK_ROLE_LIST_BOX
​https://bugs.webkit.org/show_bug.cgi?id=127060

Reviewed by Chris Fleizach.

Source/WebCore:

Corrected the mapping from ATK_ROLE_LIST to ATK_ROLE_LIST_BOX.

No new tests. Instead, updated the expectations of roles-exposed.html to
reflect the corrected mapping.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Updated the expectations to reflect the corrected role.

  • platform/efl/accessibility/roles-exposed-expected.txt: updated
  • platform/gtk/accessibility/roles-exposed-expected.txt: updated
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r176159 r176160  
     12014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] Lists with selectable children should have ATK_ROLE_LIST_BOX
     4        https://bugs.webkit.org/show_bug.cgi?id=127060
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updated the expectations to reflect the corrected role.
     9
     10        * platform/efl/accessibility/roles-exposed-expected.txt: updated
     11        * platform/gtk/accessibility/roles-exposed-expected.txt: updated
     12
    1132014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
    214

  • trunk/LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt

    r176158 r176160  
    165165     
    166166select[multiple]
    167       AXRole: AXList
     167      AXRole: AXListBox
    168168     
    169169option

  • trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt

    r176158 r176160  
    165165     
    166166select[multiple]
    167       AXRole: AXList
     167      AXRole: AXListBox
    168168     
    169169option

  • trunk/Source/WebCore/ChangeLog

    r176159 r176160  
     12014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] Lists with selectable children should have ATK_ROLE_LIST_BOX
     4        https://bugs.webkit.org/show_bug.cgi?id=127060
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Corrected the mapping from ATK_ROLE_LIST to ATK_ROLE_LIST_BOX.
     9
     10        No new tests. Instead, updated the expectations of roles-exposed.html to
     11        reflect the corrected mapping.
     12
     13        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     14        (atkRole):
     15
    1162014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
    217

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r176159 r176160  
    696696        return ATK_ROLE_HEADING;
    697697    case ListBoxRole:
    698         return ATK_ROLE_LIST;
     698        return ATK_ROLE_LIST_BOX;
    699699    case ListItemRole:
    700700        return coreObject->inheritsPresentationalRole() ? ATK_ROLE_SECTION : ATK_ROLE_LIST_ITEM;
Note: See TracChangeset for help on using the changeset viewer.