Changeset 176322 in webkit

Timestamp:

Nov 19, 2014 9:52:58 AM (9 years ago)

Author:

Philippe Normand

Message:

Missing NULL-check in VideoTrack::setLanguage
​https://bugs.webkit.org/show_bug.cgi?id=138867

Reviewed by Jer Noble.

• html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setLanguage): Prevent change event creation
on an empty video track list.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/VideoTrack.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-19  Philippe Normand  <pnormand@igalia.com>
+
+        Missing NULL-check in VideoTrack::setLanguage
+        https://bugs.webkit.org/show_bug.cgi?id=138867
+
+        Reviewed by Jer Noble.
+
+        * html/track/VideoTrack.cpp:
+        (WebCore::VideoTrack::setLanguage): Prevent change event creation
+        on an empty video track list.
+
 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/html/track/VideoTrack.cpp

@@ -218 +218 @@
     // 4. Queue a task to fire a simple event named change at the VideoTrackList object referenced by
     // the videoTracks attribute on the HTMLMediaElement.
-    mediaElement()->videoTracks()->scheduleChangeEvent();
+    if (mediaElement()->videoTracks())
+        mediaElement()->videoTracks()->scheduleChangeEvent();
 }
 #endif