Changeset 176556 in webkit


Ignore:
Timestamp:
Nov 28, 2014 1:00:54 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
​https://bugs.webkit.org/show_bug.cgi?id=139044

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.

ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::columnHeaders):

LayoutTests:

  • accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
  • platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
  • platform/gtk/TestExpectations: Updated for GTK.
  • platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r176552 r176556  
     12014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
     2
     3        [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
     4        https://bugs.webkit.org/show_bug.cgi?id=139044
     5
     6        Reviewed by Chris Fleizach.
     7
     8        ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
     9        The proposed solution will enable the use of this method for the object table.
     10        Existing test shows the result.
     11
     12        * accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
     13        * platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
     14        * platform/gtk/TestExpectations: Updated for GTK.
     15        * platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.
     16
    1172014-11-27  Joanmarie Diggs  <jdiggs@igalia.com>
    218

  • trunk/LayoutTests/accessibility/table-column-headers-with-captions.html

    r174860 r176556  
    2727        var table = accessibilityController.accessibleElementById("table");
    2828        var colHeaders = table.columnHeaders();
    29 
    30         shouldBeTrue("colHeaders[0].isEqual(table.rowAtIndex(0).childAtIndex(0))");
    31         shouldBeTrue("colHeaders[1].isEqual(table.rowAtIndex(0).childAtIndex(1))");
     29        if (accessibilityController.platformName == "atk") {
     30            shouldBeTrue("colHeaders[0].isEqual(table.cellForColumnAndRow(0,0))");
     31            shouldBeTrue("colHeaders[1].isEqual(table.cellForColumnAndRow(1,0))");
     32        } else {
     33            shouldBeTrue("colHeaders[0].isEqual(table.rowAtIndex(0).childAtIndex(0))");
     34            shouldBeTrue("colHeaders[1].isEqual(table.rowAtIndex(0).childAtIndex(1))");
     35        }
    3236    }
    3337

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r176197 r176556  
    22322232
    22332233webkit.org/b/137109 accessibility/legend-children-are-visible.html [ Failure ]
    2234 webkit.org/b/138069 accessibility/table-column-headers-with-captions.html [ Failure ]
    22352234
    22362235webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ]

  • trunk/Tools/ChangeLog

    r176555 r176556  
     12014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
     2
     3        [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
     4        https://bugs.webkit.org/show_bug.cgi?id=139044
     5
     6        Reviewed by Chris Fleizach.
     7
     8        ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
     9        The proposed solution will enable the use of this method for the object table.
     10        Existing test shows the result.
     11
     12        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     13        (WTR::AccessibilityUIElement::columnHeaders):
     14
    1152014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
    216

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r176162 r176556  
    956956{
    957957#if ATK_CHECK_VERSION(2,11,90)
    958     if (!ATK_IS_TABLE_CELL(m_element.get()))
     958    if (!ATK_IS_TABLE_CELL(m_element.get()) && !ATK_IS_TABLE(m_element.get()))
    959959        return nullptr;
    960960
    961     GRefPtr<GPtrArray> array = adoptGRef(atk_table_cell_get_column_header_cells(ATK_TABLE_CELL(m_element.get())));
    962     if (!array)
    963         return nullptr;
    964 
    965     Vector<RefPtr<AccessibilityUIElement>> columns = convertGPtrArrayToVector(array.get());
     961    Vector<RefPtr<AccessibilityUIElement>> columns;
     962    if (ATK_IS_TABLE_CELL(m_element.get())) {
     963        GRefPtr<GPtrArray> array = adoptGRef(atk_table_cell_get_column_header_cells(ATK_TABLE_CELL(m_element.get())));
     964        if (!array)
     965            return nullptr;
     966
     967        columns = convertGPtrArrayToVector(array.get());
     968    } else
     969        columns = getColumnHeaders(ATK_TABLE(m_element.get()));
    966970    return convertToJSObjectArray(columns);
    967971#else
Note: See TracChangeset for help on using the changeset viewer.