Changeset 176853 in webkit


Ignore:
Timestamp:
Dec 5, 2014 10:48:05 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Uncaught Exceptions when attempting to show Content Flow
​https://bugs.webkit.org/show_bug.cgi?id=139276

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-05
Reviewed by Brian Burg.

  • UserInterface/Views/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
LegacyJavaScriptProfileObject no longer exists, these references should be removed.

  • UserInterface/Views/FolderizedTreeElement.js:

(WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
This sort function references "this" and needed to be bound.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r176819 r176853  
     12014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Uncaught Exceptions when attempting to show Content Flow
     4        https://bugs.webkit.org/show_bug.cgi?id=139276
     5
     6        Reviewed by Brian Burg.
     7
     8        * UserInterface/Views/ContentView.js:
     9        (WebInspector.ContentView):
     10        (WebInspector.ContentView.isViewable):
     11        LegacyJavaScriptProfileObject no longer exists, these references should be removed.
     12
     13        * UserInterface/Views/FolderizedTreeElement.js:
     14        (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
     15        This sort function references "this" and needed to be bound.
     16
    1172014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
    218

  • trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js

    r164543 r176853  
    7070            return new WebInspector.LogContentView(representedObject);
    7171
    72         if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
    73             return new WebInspector.LegacyJavaScriptProfileView(representedObject);
    74 
    7572        if (representedObject instanceof WebInspector.ContentFlow)
    7673            return new WebInspector.ContentFlowDOMTreeContentView(representedObject);
    … …  
    127124        return true;
    128125    if (representedObject instanceof WebInspector.LogObject)
    129         return true;
    130     if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
    131126        return true;
    132127    if (representedObject instanceof WebInspector.ContentFlow)

  • trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js

    r175784 r176853  
    238238    {
    239239        console.assert(!childTreeElement.parent);
    240         parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements));
     240        parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements.bind(this)));
    241241    },
    242242
Note: See TracChangeset for help on using the changeset viewer.