Changeset 177029 in webkit

Timestamp:

Dec 9, 2014 11:39:29 AM (9 years ago)

Author:

ggaren@apple.com

Message:

Re-enable function.arguments
​https://bugs.webkit.org/show_bug.cgi?id=139452
Source/JavaScriptCore:

<rdar://problem/18848149>

Reviewed by Sam Weinig.

Disabling function.arguments broke a few websites, and we don't have
time right now to work through the details.

I'm re-enabling function.arguments but leaving in the infrastructure
to re-disable it, so we can try this experiment again in the future.

• runtime/Options.h:

LayoutTests:

Reviewed by Sam Weinig.

• TestExpectations: Re-enable these tests, since WebKit supports this

feature by default now.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/Options.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-12-09  Geoffrey Garen  <ggaren@apple.com>
+
+        Re-enable function.arguments
+        https://bugs.webkit.org/show_bug.cgi?id=139452
+
+        Reviewed by Sam Weinig.
+
+        * TestExpectations: Re-enable these tests, since WebKit supports this
+        feature by default now.
+
 2014-12-09  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -174 +174 @@
 # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases.
 webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ]
-
-# Deprecated tests for function.arguments. These tests need to stay in the tree because the RJST
-# harness will run these after forcibly reenabling the function.arguments feature. We want to
-# keep testing the feature for as long as we haven't achieved confidence that it is safe to
-# remove it entirely.
-webkit.org/b/137167 js/dfg-arguments-unexpected-escape.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-become-double.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-become-int32.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-int32.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-osr-exit-and-capture.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-reset-changetype.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-reset.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-simple.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-directly-from-inlined-code.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-all-the-places.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-getter.html [ Failure ]
-webkit.org/b/137167 js/dfg-inline-arguments-use-from-uninlined-code.html [ Failure ]
-webkit.org/b/137167 js/dfg-tear-off-arguments-not-activation.html [ Failure ]
-webkit.org/b/137167 js/dfg-tear-off-function-dot-arguments.html [ Failure ]
-webkit.org/b/137167 js/dom/exception-thrown-from-function-with-lazy-activation.html [ Failure ]
-webkit.org/b/137167 js/dom/function-dot-arguments2.html [ Failure ]
-webkit.org/b/137167 js/function-dot-arguments.html [ Failure ]
-webkit.org/b/137167 js/kde/function.html [ Failure ]
-webkit.org/b/137167 js/kde/function_arguments.html [ Failure ]
 
 # Promises/A+ 2.3.3 has many tests and it sometimes exceeds the time limit.

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-12-09  Geoffrey Garen  <ggaren@apple.com>
+
+        Re-enable function.arguments
+        https://bugs.webkit.org/show_bug.cgi?id=139452
+        <rdar://problem/18848149>
+
+        Reviewed by Sam Weinig.
+
+        Disabling function.arguments broke a few websites, and we don't have
+        time right now to work through the details.
+
+        I'm re-enabling function.arguments but leaving in the infrastructure
+        to re-disable it, so we can try this experiment again in the future.
+
+        * runtime/Options.h:
+
 2014-12-09  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -113 +113 @@
     v(bool, forceProfilerBytecodeGeneration, false) \
     \
-    v(bool, enableFunctionDotArguments, false) \
+    v(bool, enableFunctionDotArguments, true) \
     \
     /* showDisassembly implies showDFGDisassembly. */ \