Changeset 17789 in webkit


Ignore:
Timestamp:
Nov 15, 2006 12:04:23 PM (17 years ago)
Author:
spadma
Message:

2006-11-13 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Valid email address cannot be identified on a page when smart text is on. Remove garbage characters from being appended to descriptor prior to calling the FindItemEngine.
http://bugs.webkit.org/show_bug.cgi?id=11589

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL):
  • bridge/WebCoreBridge.h:
Location:
S60/trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • S60/trunk/WebCore/ChangeLog

    r17693 r17789  
     12006-11-13  ligman  <joseph.ligman@nokia.com>
     2
     3        Reviewed by Sachin.
     4        DESC: Valid email address cannot be identified on a page when smart text is on. Remove garbage characters from being appended to descriptor prior to calling the FindItemEngine.
     5        http://bugs.webkit.org/show_bug.cgi?id=11589
     6
     7        WARNING: NO TEST CASES ADDED OR CHANGED
     8
     9        * bridge/WebCoreBridge.cpp:
     10        (CWebCoreBridge::~CWebCoreBridge):
     11        (CWebCoreBridge::GetNextRenderTextForSmartLinksL):
     12        * bridge/WebCoreBridge.h:
     13
    1142006-11-09  raalexan  <rasvan.alexandrescu@nokia.com>
    215
  • S60/trunk/WebCore/bridge/WebCoreBridge.cpp

    r17301 r17789  
    166166    iPart->setBridge(0);
    167167    iPart->deref();
    168 
    169     delete iSmartTextBuffer;
     168   
    170169    }
    171170
     
    14671466            {
    14681467            aContinue = ETrue;
    1469             RenderText* textRenderer = static_cast<RenderText *>(iSmartLinkNode->renderer());
    1470             delete iSmartTextBuffer;
    1471             iSmartTextBuffer = NULL;
    1472             iSmartTextBuffer = textRenderer->data().string().Des().AllocL();
    1473             return iSmartTextBuffer->Ptr();
     1468            RenderText* textRenderer = static_cast<RenderText *>(iSmartLinkNode->renderer());                       
     1469            return TPtrC ((const TUint16 *)textRenderer->data().unicode(), textRenderer->data().length());
    14741470            }
    14751471        }
  • S60/trunk/WebCore/bridge/WebCoreBridge.h

    r17301 r17789  
    524524        //pointer for render text object for smart link parsing
    525525        DOM::NodeImpl* iSmartLinkNode;
    526         //pointer for smart text buffer
    527         HBufC* iSmartTextBuffer;
    528526
    529527    };
Note: See TracChangeset for help on using the changeset viewer.