Changeset 177927 in webkit

Timestamp:

Jan 5, 2015 1:44:32 PM (9 years ago)

Author:

Chris Dumez

Message:

Regression(r163928): Animated images are not resumed on window resizing
​https://bugs.webkit.org/show_bug.cgi?id=139714
<rdar://problem/18855285>

Reviewed by Darin Adler.

Source/WebCore:

After r163928, animated images were not resumed if they became visible
after resizing the window. This patch calls resumes animated images if
necessary in FrameView::setFrameRect() to handle this case properly.

Tests: fast/images/animated-gif-window-resizing.html

fast/images/animated-gif-zooming.html

• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

LayoutTests:

Add a layout test to make sure animated images are correctly paused /
resumed when resizing the window.

Also add another test to make sure animated images are correctly paused
/ resumed when zooming in and out.

• fast/images/animated-gif-window-resizing-expected.txt: Added.
• fast/images/animated-gif-window-resizing.html: Added.
• fast/images/animated-gif-zooming-expected.txt: Added.
• fast/images/animated-gif-zooming.html: Added.
• fast/images/resources/animated-gif-window-resize.html: Added.
• platform/mac-wk1/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/images/animated-gif-window-resizing-expected.txt (added)
• LayoutTests/fast/images/animated-gif-window-resizing.html (added)
• LayoutTests/fast/images/animated-gif-zooming-expected.txt (added)
• LayoutTests/fast/images/animated-gif-zooming.html (added)
• LayoutTests/fast/images/resources/animated-gif-window-resize.html (added)
• LayoutTests/platform/mac-wk1/TestExpectations (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-01-05  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r163928): Animated images are not resumed on window resizing
+        https://bugs.webkit.org/show_bug.cgi?id=139714
+        <rdar://problem/18855285>
+
+        Reviewed by Darin Adler.
+
+        Add a layout test to make sure animated images are correctly paused /
+        resumed when resizing the window.
+
+        Also add another test to make sure animated images are correctly paused
+        / resumed when zooming in and out.
+
+        * fast/images/animated-gif-window-resizing-expected.txt: Added.
+        * fast/images/animated-gif-window-resizing.html: Added.
+        * fast/images/animated-gif-zooming-expected.txt: Added.
+        * fast/images/animated-gif-zooming.html: Added.
+        * fast/images/resources/animated-gif-window-resize.html: Added.
+        * platform/mac-wk1/TestExpectations:
+
 2015-01-05  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -28 +28 @@
 
 webkit.org/b/112533 media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Timeout ]
-
-webkit.org/b/139599 fast/images/animated-gif-body-outside-viewport.html [ Pass Failure Timeout ]
 
 webkit.org/b/139778 fullscreen/exit-full-screen-iframe.html [ Skip ]
@@ -67 +65 @@
 plugins/snapshotting
 
+# Animated image throttling behaves differently on WK1.
+fast/images/animated-gif-body-outside-viewport.html [ Skip ]
+fast/images/animated-gif-window-resizing.html [ Skip ]
+fast/images/animated-gif-zooming.html [ Skip ]
+
 # Mavericks and prior do not support contentInset
 [ MountainLion Mavericks ] platform/mac/fast/events/content-inset-hit-testing.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-01-05  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r163928): Animated images are not resumed on window resizing
+        https://bugs.webkit.org/show_bug.cgi?id=139714
+        <rdar://problem/18855285>
+
+        Reviewed by Darin Adler.
+
+        After r163928, animated images were not resumed if they became visible
+        after resizing the window. This patch calls resumes animated images if
+        necessary in FrameView::setFrameRect() to handle this case properly.
+
+        Tests: fast/images/animated-gif-window-resizing.html
+               fast/images/animated-gif-zooming.html
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setFrameRect):
+
 2015-01-01  Brian J. Burg  <burg@cs.washington.edu>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -459 +459 @@
     if (frame().isMainFrame())
         frame().mainFrame().pageOverlayController().didChangeViewSize();
+
+    // The frame view was resized, check if we should resume animated images.
+    resumeVisibleImageAnimationsIncludingSubframes();
 }