Changeset 178063 in webkit


Ignore:
Timestamp:
Jan 7, 2015 3:56:01 PM (9 years ago)
Author:
mmaxfield@apple.com
Message:

Update css3/flexbox/auto-margins.html after r177774
​https://bugs.webkit.org/show_bug.cgi?id=139975

Patch by Myles C. Maxfield <​litherum@gmail.com> on 2015-01-07
Reviewed by Darin Adler.

This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire
box and therefore does all its math in floating point, while the
-expected uses the regular renderer hierarchy and therefore fixed-point
math. This patch updates the test to use Ahem so that the character
widths divide the same way in both cases.

  • css3/flexbox/auto-margins-expected.html:
  • css3/flexbox/auto-margins.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r178061 r178063  
     12015-01-07  Myles C. Maxfield  <litherum@gmail.com>
     2
     3        Update css3/flexbox/auto-margins.html after r177774
     4        https://bugs.webkit.org/show_bug.cgi?id=139975
     5
     6        Reviewed by Darin Adler.
     7
     8        This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire
     9        box and therefore does all its math in floating point, while the
     10        -expected uses the regular renderer hierarchy and therefore fixed-point
     11        math. This patch updates the test to use Ahem so that the character
     12        widths divide the same way in both cases.
     13
     14        * css3/flexbox/auto-margins-expected.html:
     15        * css3/flexbox/auto-margins.html:
     16        * platform/mac/TestExpectations:
     17
    1182015-01-07  Brent Fulgham  <bfulgham@apple.com>
    219

  • trunk/LayoutTests/css3/flexbox/auto-margins-expected.html

    r118279 r178063  
    1717<p>These tests are from the spec: <a href="http://dev.w3.org/csswg/css3-flexbox/#auto-margins">http://dev.w3.org/csswg/css3-flexbox/#auto-margins</a>.</p>
    1818
    19 <p>The word OK should be centered vertically and horizontally.</p>
     19<p>A black box should be centered vertically and horizontally.</p>
    2020<div style="width: 4em; height: 4em; background: silver">
    21   <table style="width: 100%; height: 100%;"><tr><td style="text-align: center">OK</td></tr></table>
     21  <table style="width: 100%; height: 100%;"><tr><td style="text-align: center; font-family: Ahem;">OK</td></tr></table>
    2222</div>
    2323
    2424<div style="width: 4em; height: 4em; margin-top: 10px; background: silver; -webkit-writing-mode: vertical-rl">
    25   <table style="width: 100%; height: 100%;"><tr><td style="text-align: center">OK</td></tr></table>
     25  <table style="width: 100%; height: 100%;"><tr><td style="text-align: center; font-family: Ahem;">OK</td></tr></table>
    2626</div>
    2727

  • trunk/LayoutTests/css3/flexbox/auto-margins.html

    r130457 r178063  
    2424<p>These tests are from the spec: <a href="http://dev.w3.org/csswg/css3-flexbox/#auto-margins">http://dev.w3.org/csswg/css3-flexbox/#auto-margins</a>.</p>
    2525
    26 <p>The word OK should be centered vertically and horizontally.</p>
     26<p>A black box should be centered vertically and horizontally.</p>
    2727<div class="flexbox" style="width: 4em; height: 4em; background: silver">
    28   <p id="ok" style="margin: auto;">OK</p>
     28  <p id="ok" style="margin: auto; font-family: Ahem;">OK</p>
    2929</div>
    3030
    3131<div class="flexbox" style="width: 4em; height: 4em; margin-top: 10px; background: silver; -webkit-writing-mode: vertical-rl">
    32   <p id="okVertical" style="margin: auto;">OK</p>
     32  <p id="okVertical" style="margin: auto; font-family: Ahem;">OK</p>
    3333</div>
    3434

  • trunk/LayoutTests/platform/mac/TestExpectations

    r177919 r178063  
    13401340# Kerning, Ligatures, and Printer Fonts caused these tests to fail
    13411341# The following tests are reftests
    1342 webkit.org/b/139968 css3/flexbox/auto-margins.html [ ImageOnlyFailure ]
    13431342webkit.org/b/139968 css3/flexbox/csswg/flexbox_direction-row-reverse.html [ ImageOnlyFailure ]
    13441343webkit.org/b/139968 fast/box-decoration-break/box-decoration-break-rendering.html [ ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.