Changeset 179248 in webkit


Ignore:
Timestamp:
Jan 28, 2015 5:44:56 AM (9 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
https://bugs.webkit.org/show_bug.cgi?id=131731

Reviewed by Žan Doberšek.

A web page loaded offscreen is in prerender state not hidden.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewPageVisibility):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r179240 r179248  
     12015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
     4        https://bugs.webkit.org/show_bug.cgi?id=131731
     5
     6        Reviewed by Žan Doberšek.
     7
     8        A web page loaded offscreen is in prerender state not hidden.
     9
     10        * Scripts/run-gtk-tests:
     11        (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
     12        * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
     13        (testWebViewPageVisibility):
     14
    1152015-01-27  Alexey Proskuryakov  <ap@apple.com>
    216
  • trunk/Tools/Scripts/run-gtk-tests

    r178644 r179248  
    6565        SkippedTest("WebKit2Gtk/TestContextMenu", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
    6666        SkippedTest("WebKit2APITests/TestWebKitAccessibility", "/webkit2/WebKitAccessibility/atspi-basic-hierarchy", "Test is flaky", 132134),
    67         SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/page-visibility", "Test fails or times out", 131731),
    6867        SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
    6968        SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
  • trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp

    r178700 r179248  
    456456}
    457457
    458 // To test page visibility API. Currently only 'visible' and 'hidden' states are implemented fully in WebCore.
     458// To test page visibility API. Currently only 'visible', 'hidden' and 'prerender' states are implemented fully in WebCore.
    459459// See also http://www.w3.org/TR/2011/WD-page-visibility-20110602/ and https://developers.google.com/chrome/whitepapers/pagevisibility
    460460static void testWebViewPageVisibility(WebViewTest* test, gconstpointer)
     
    471471        0);
    472472
    473     // Wait untill the page is loaded. Initial visibility should be 'hidden'.
     473    // Wait until the page is loaded. Initial visibility should be 'prerender'.
    474474    test->waitUntilLoadFinished();
    475475
     
    479479    g_assert(!error.get());
    480480    GUniquePtr<char> valueString(WebViewTest::javascriptResultToCString(javascriptResult));
    481     g_assert_cmpstr(valueString.get(), ==, "hidden");
     481    g_assert_cmpstr(valueString.get(), ==, "prerender");
    482482
    483483    javascriptResult = test->runJavaScriptAndWaitUntilFinished("document.hidden;", &error.outPtr());
Note: See TracChangeset for help on using the changeset viewer.