Changeset 179572 in webkit

Timestamp:

Feb 3, 2015 3:02:40 PM (9 years ago)

Author:

ap@apple.com

Message:

http/tests/xmlhttprequest/event-listener-gc.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33342

Reviewed by Zalan Bujtas.

This failure means that the GC timer fires after readystatechange event. As a
speculative fix, start the timer before starting the load, so that it's certain to
finish earlier.

• http/tests/xmlhttprequest/event-listener-gc.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/xmlhttprequest/event-listener-gc.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-03  Alexey Proskuryakov  <ap@apple.com>
+
+        http/tests/xmlhttprequest/event-listener-gc.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=33342
+
+        Reviewed by Zalan Bujtas.
+
+        This failure means that the GC timer fires after readystatechange event. As a
+        speculative fix, start the timer before starting the load, so that it's certain to
+        finish earlier.
+
+        * http/tests/xmlhttprequest/event-listener-gc.html:
+
 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
 

trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html

@@ -31 +31 @@
         testRunner.waitUntilDone();
     }
-        
+
+    // Timeout ensures stack references to request are cleared when we collect.
+    // Start the timer before starting the load, so that it's guaranteed to fire first.
+    setTimeout('collect();', 0);
+
     var request = new XMLHttpRequest();
     request.onreadystatechange = processStateChange;
     request.open("GET", "print-content-type.cgi", true);
     request.send(null);
-    
-    setTimeout('collect();', 0); // timeout ensures stack references to request are cleared when we collect
 }
 </script>