Changeset 179713 in webkit

Timestamp:

Feb 5, 2015 2:47:40 PM (9 years ago)

Author:

jonowells@apple.com

Message:

Web Inspector: REGRESSION: Inline SourceMap resources show empty content when opened.
​https://bugs.webkit.org/show_bug.cgi?id=141225

Reviewed by Timothy Hatcher.

Change WebInspector.SourceMapResource.prototype.requestContentFromBackend to correctly and consistently handle
calls to NetworkAgent. The helper function sourceMapResourceLoaded will now properly handle parameters as a single
payload, including manual calls in the case where the source map content is in a data URI. Also
WebInspector.SourceCode.prototype._processContent now properly handles an error string used for displaying
resource loading error messages in the resource content view.

• UserInterface/Models/Resource.js: drive-by style fix.

• UserInterface/Models/SourceCode.js:

(WebInspector.SourceCode.prototype._processContent):
Properly handle error string.

• UserInterface/Models/SourceMapResource.js:

(WebInspector.SourceMapResource.prototype.requestContentFromBackend):
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
Formerly sourceMapResourceLoadError, now handles parameters from the NetworkAgent correctly.

(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
This function now handles NetworkAgent errors only.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Resource.js (modified) (1 diff)
• UserInterface/Models/SourceCode.js (modified) (2 diffs)
• UserInterface/Models/SourceMapResource.js (modified) (6 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-02-04  Jono Wells  <jonowells@apple.com>
+
+        Web Inspector: REGRESSION: Inline SourceMap resources show empty content when opened.
+        https://bugs.webkit.org/show_bug.cgi?id=141225
+
+        Reviewed by Timothy Hatcher.
+
+        Change WebInspector.SourceMapResource.prototype.requestContentFromBackend to correctly and consistently handle
+        calls to NetworkAgent. The helper function sourceMapResourceLoaded will now properly handle parameters as a single
+        payload, including manual calls in the case where the source map content is in a data URI. Also
+        WebInspector.SourceCode.prototype._processContent now properly handles an error string used for displaying
+        resource loading error messages in the resource content view.
+
+        * UserInterface/Models/Resource.js: drive-by style fix.
+
+        * UserInterface/Models/SourceCode.js:
+        (WebInspector.SourceCode.prototype._processContent):
+        Properly handle error string.
+
+        * UserInterface/Models/SourceMapResource.js:
+        (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
+        (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
+        Formerly sourceMapResourceLoadError, now handles parameters from the NetworkAgent correctly.
+
+        (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
+        This function now handles NetworkAgent errors only.
+
 2015-02-05  Brian J. Burg  <burg@cs.washington.edu>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js

@@ -681 +681 @@
 
         if (this._failed)
-            return Promise.resolve({ error: WebInspector.UIString("An error occurred trying to load the resource.") });
+            return Promise.resolve({error: WebInspector.UIString("An error occurred trying to load the resource.")});
 
         if (!this._finishThenRequestContentPromise) {

trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js

@@ -192 +192 @@
         // Different backend APIs return one of `content, `body`, or `scriptSource`.
         var content = parameters.content || parameters.body || parameters.scriptSource;
+        var error = parameters.error;
         var base64Encoded = parameters.base64Encoded;
 
@@ -202 +203 @@
 
         return Promise.resolve({
+            error: error,
             sourceCode: this,
             content: content,

trunk/Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js

@@ -50 +50 @@
 WebInspector.SourceMapResource.prototype = {
     constructor: WebInspector.SourceMapResource,
+    __proto__: WebInspector.Resource.prototype,
 
     // Public
@@ -85 +86 @@
             // FIXME: We don't know the MIME-type for inline content. Guess by analyzing the content?
             // Returns a promise.
-            return sourceMapResourceLoaded.call(this, null, inlineContent, this.mimeType, 200);
+            return sourceMapResourceLoaded.call(this, {content: inlineContent, mimeType: this.mimeType, status: 200});
         }
 
-        function sourceMapResourceLoadError(error, body, mimeType, statusCode)
+        function sourceMapResourceNotAvailable(error, content, mimeType, statusCode)
         {
             this.markAsFailed();
             return Promise.resolve({
-                error: error,
-                content: body.content,
+                error: WebInspector.UIString("An error occurred trying to load the resource."),
+                content: content,
                 mimeType: mimeType,
                 statusCode: statusCode
@@ -99 +100 @@
         }
 
-        function sourceMapResourceLoaded(body, mimeType, statusCode)
+        function sourceMapResourceLoadError(error)
         {
+            // There was an error calling NetworkAgent.loadResource.
+            console.error(error || "There was an unknown error calling NetworkAgent.loadResource.");
+            this.markAsFailed();
+            return Promise.resolve({error: WebInspector.UIString("An error occurred trying to load the resource.")});
+        }
+
+        function sourceMapResourceLoaded(parameters)
+        {
+            var {error, content, mimeType, statusCode} = parameters;
+
             const base64encoded = false;
 
-            if (statusCode >= 400)
-                return sourceMapResourceLoadError(error, body, mimeType, statusCode);
+            if (statusCode >= 400 || error)
+                return sourceMapResourceNotAvailable(error, content, mimeType, statusCode);
 
             // FIXME: Add support for picking the best MIME-type. Right now the file extension is the best bet.
@@ -112 +123 @@
 
             return Promise.resolve({
-                content: body.content,
+                content: content,
                 mimeType: mimeType,
                 base64encoded: base64encoded,
@@ -119 +130 @@
         }
 
-        if (!NetworkAgent.loadResource) {
-            sourceMapResourceLoaded.call(this, "error: no NetworkAgent.loadResource");
-            return Promise.reject(new Error("No NetworkAgent.loadResource"));
-        }
+        if (!NetworkAgent.loadResource)
+            return sourceMapResourceLoadError.call(this);
 
         var frameIdentifier = null;
@@ -164 +173 @@
     }
 };
-
-WebInspector.SourceMapResource.prototype.__proto__ = WebInspector.Resource.prototype;