Changeset 179787 in webkit

Timestamp:

Feb 7, 2015 4:32:54 PM (9 years ago)

Author:

Chris Dumez

Message:

fast/images/animated-gif-iframe-webkit-transform.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=141323

Reviewed by Alexey Proskuryakov.

Use shouldBecomeEqual() instead of shouldBe() to check for initial test
conditions. This should address the flakiness.

• fast/images/animated-gif-iframe-webkit-transform-expected.txt:
• fast/images/animated-gif-iframe-webkit-transform.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/images/animated-gif-iframe-webkit-transform-expected.txt (modified) (1 diff)
• fast/images/animated-gif-iframe-webkit-transform.html (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-07  Chris Dumez  <cdumez@apple.com>
+
+        fast/images/animated-gif-iframe-webkit-transform.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=141323
+
+        Reviewed by Alexey Proskuryakov.
+
+        Use shouldBecomeEqual() instead of shouldBe() to check for initial test
+        conditions. This should address the flakiness.
+
+        * fast/images/animated-gif-iframe-webkit-transform-expected.txt:
+        * fast/images/animated-gif-iframe-webkit-transform.html:
+        * platform/mac/TestExpectations:
+
 2015-02-07  Darin Adler  <darin@apple.com>
 

trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform-expected.txt

@@ -5 +5 @@
 
  
-PASS isFirstImagePaused() is false
-PASS isSecondImagePaused() became true
+PASS !isFirstImagePaused() && isSecondImagePaused() became true
 PASS isFirstImagePaused() is false
 Translating images left so that first image is no longer visible, but second image is.

trunk/LayoutTests/fast/images/animated-gif-iframe-webkit-transform.html

@@ -71 +71 @@
   if (numberFramesLoaded != 2)
     return;
-  shouldBeFalse("isFirstImagePaused()");
-  shouldBecomeEqual("isSecondImagePaused()", "true", translateImagesLeft);
+  shouldBecomeEqual("!isFirstImagePaused() && isSecondImagePaused()", "true", translateImagesLeft);
 }
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1405 +1405 @@
 fast/forms/focus-selection-textarea.html [ Pass Failure ]
 
-webkit.org/b/141323 fast/images/animated-gif-iframe-webkit-transform.html [ Pass Failure ]