Changeset 179789 in webkit

Timestamp:

Feb 7, 2015 4:53:49 PM (9 years ago)

Author:

ap@apple.com

Message:

http/tests/xmlhttprequest/event-listener-gc.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33342

Reviewed by Darin Adler.

This test relies on a zero-delay timer being a lot faster than fetching from network.
Force a layout before starting the test, because otherwise, the layout can significantly
delay the timer (I've seen 50-60 milliseconds being a common delay in debug builds).

Also, changed the resource URL to avoid Apache error log spew.

• http/tests/xmlhttprequest/event-listener-gc.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/xmlhttprequest/event-listener-gc.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-07  Alexey Proskuryakov  <ap@apple.com>
+
+        http/tests/xmlhttprequest/event-listener-gc.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=33342
+
+        Reviewed by Darin Adler.
+
+        This test relies on a zero-delay timer being a lot faster than fetching from network.
+        Force a layout before starting the test, because otherwise, the layout can significantly
+        delay the timer (I've seen 50-60 milliseconds being a common delay in debug builds).
+
+        Also, changed the resource URL to avoid Apache error log spew.
+
+        * http/tests/xmlhttprequest/event-listener-gc.html:
+
 2015-02-07  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html

@@ -31 +31 @@
     }
 
-    // Timeout ensures stack references to request are cleared when we collect.
-    // Start the timer before starting the load, so that it's guaranteed to fire first.
-    setTimeout('collect();', 0);
+    // Force layout now, as otherwise it will occur before our garbage collection timer,
+    // possibly delaying it until after XMLHttpRequest finishes.
+    document.body.offsetTop;
 
     var request = new XMLHttpRequest();
     request.onreadystatechange = processStateChange;
-    request.open("GET", "print-content-type.cgi", true);
+    request.open("GET", "resources/print-headers.cgi", true);
     request.send(null);
+
+    setTimeout('collect();', 0);
 }
 </script>