Changeset 179794 in webkit

Timestamp:

Feb 7, 2015 9:24:25 PM (9 years ago)

Author:

ap@apple.com

Message:

fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
​https://bugs.webkit.org/show_bug.cgi?id=141364

Reviewed by Zalan Bujtas.

Speculative fix. Make sure that the plug-in has loaded before using it.

• fullscreen/full-screen-plugin.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fullscreen/full-screen-plugin.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-07  Alexey Proskuryakov  <ap@apple.com>
+
+        fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
+        https://bugs.webkit.org/show_bug.cgi?id=141364
+
+        Reviewed by Zalan Bujtas.
+
+        Speculative fix. Make sure that the plug-in has loaded before using it.
+
+        * fullscreen/full-screen-plugin.html:
+
 2015-02-07  Tim Horton  <timothy_horton@apple.com>
 

trunk/LayoutTests/fullscreen/full-screen-plugin.html

@@ -7 +7 @@
 <div>
     <div>Test that plugin doesn't restart when taking it to full screen and back.</div>
-    <div id="result">Test didn't run'</div>
+    <div id="result">Test didn't run</div>
     <embed id="plugin" type="application/x-webkit-test-netscape" width="200" height="200"></embed>
 </div>
 
 <script>
-if ("webkitRequestFullScreen" in Element.prototype) {
+onload = function() {
     var callback;
     var fullscreenChanged = function(event)
@@ -24 +24 @@
     var plugin = document.getElementById('plugin');
     var testObject = plugin.testObject;
+    testObject.property = 'foo'; // Verify that setting a property works before going fullscreen.
 
     var spanEnteredFullScreen = function(event) {