Changeset 179821 in webkit

Timestamp:

Feb 9, 2015 12:02:34 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
​https://bugs.webkit.org/show_bug.cgi?id=141333

Reviewed by Žan Doberšek.

Create an initialize WebPreferences for the inspector page. This
was moved from cross-platform code to platform specific code.

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WebInspectorProxyGtk.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
+        https://bugs.webkit.org/show_bug.cgi?id=141333
+
+        Reviewed by Žan Doberšek.
+
+        Create an initialize WebPreferences for the inspector page. This
+        was moved from cross-platform code to platform specific code.
+
+        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+
 2015-02-08  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp

@@ -62 +62 @@
     ASSERT(inspectedPage());
     ASSERT(!m_inspectorView);
-    RefPtr<WebPageGroup> pageGroup = WebPageGroup::create(inspectorPageGroupIdentifier(), false, false).leakRef();
-    m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(&inspectorProcessPool(), nullptr, pageGroup.get(), nullptr, nullptr));
+
+    RefPtr<WebPreferences> preferences = WebPreferences::create(String(), "WebKit2.", "WebKit2.");
+#ifndef NDEBUG
+    // Allow developers to inspect the Web Inspector in debug builds without changing settings.
+    preferences->setDeveloperExtrasEnabled(true);
+    preferences->setLogsPageMessagesToSystemConsoleEnabled(true);
+#endif
+    preferences->setAllowFileAccessFromFileURLs(true);
+    RefPtr<WebPageGroup> pageGroup = WebPageGroup::create(inspectorPageGroupIdentifier(), false, false);
+    m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(&inspectorProcessPool(), preferences.get(), pageGroup.get(), nullptr, nullptr));
     g_object_add_weak_pointer(G_OBJECT(m_inspectorView), reinterpret_cast<void**>(&m_inspectorView));
+
     return webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_inspectorView));
 }