Changeset 179828 in webkit

Timestamp:

Feb 9, 2015 8:37:41 AM (9 years ago)

Author:

Brian Burg

Message:

REGRESSION(r179705): 2nd-level inspector availability no longer controlled by DeveloperExtrasEnabled user default
​https://bugs.webkit.org/show_bug.cgi?id=141343

Reviewed by Timothy Hatcher.

The regression was caused by the switch to using WKWebViewConfiguration and
its default WebPreferences object, which is used to populate the inspector page's
Settings object. This WebPreferences is initialized with no identifier, so
only preferences in the FOR_EACH_WEBKIT_DEBUG_*_PREFERENCE macros are populated
from NSUserDefaults.

The simplest fix is to move DeveloperExtrasEnabled into the DEBUG group.

Previously, each inspector level had a unique identifier such as
WebInspectorPageGroupLevelN, and the n+1 level inspector was enabled
by toggling WebInspectorPageGroupLevelN.WebKit2DeveloperExrasEnabled.
With the move to the DEBUG group, the preference becomes simply
WebKitDeveloperExtrasEnabled, which enables any level of inspector.
(This does not clash with Safari's "Show Develop Menu" preference, which uses
the key "WebKitDeveloperExtrasEnabledPreferenceKey")

• Shared/WebPreferencesDefinitions.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesDefinitions.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
+
+        REGRESSION(r179705): 2nd-level inspector availability no longer controlled by DeveloperExtrasEnabled user default
+        https://bugs.webkit.org/show_bug.cgi?id=141343
+
+        Reviewed by Timothy Hatcher.
+
+        The regression was caused by the switch to using WKWebViewConfiguration and
+        its default WebPreferences object, which is used to populate the inspector page's
+        Settings object. This WebPreferences is initialized with no identifier, so
+        only preferences in the FOR_EACH_WEBKIT_DEBUG_*_PREFERENCE macros are populated
+        from NSUserDefaults.
+
+        The simplest fix is to move DeveloperExtrasEnabled into the DEBUG group.
+
+        Previously, each inspector level had a unique identifier such as
+        __WebInspectorPageGroupLevelN__, and the n+1 level inspector was enabled
+        by toggling __WebInspectorPageGroupLevelN__.WebKit2DeveloperExrasEnabled.
+        With the move to the DEBUG group, the preference becomes simply
+        WebKitDeveloperExtrasEnabled, which enables any level of inspector.
+        (This does not clash with Safari's "Show Develop Menu" preference, which uses
+        the key "WebKitDeveloperExtrasEnabledPreferenceKey")
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2015-02-08  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -96 +96 @@
     macro(XSSAuditorEnabled, xssAuditorEnabled, Bool, bool, true) \
     macro(FrameFlatteningEnabled, frameFlatteningEnabled, Bool, bool, DEFAULT_FRAME_FLATTENING_ENABLED) \
-    macro(DeveloperExtrasEnabled, developerExtrasEnabled, Bool, bool, false) \
     macro(JavaScriptExperimentsEnabled, javaScriptExperimentsEnabled, Bool, bool, false) \
     macro(PrivateBrowsingEnabled, privateBrowsingEnabled, Bool, bool, false) \
@@ -227 +226 @@
     macro(TiledScrollingIndicatorVisible, tiledScrollingIndicatorVisible, Bool, bool, false) \
     macro(SimpleLineLayoutDebugBordersEnabled, simpleLineLayoutDebugBordersEnabled, Bool, bool, false) \
+    macro(DeveloperExtrasEnabled, developerExtrasEnabled, Bool, bool, false) \
     macro(LogsPageMessagesToSystemConsoleEnabled, logsPageMessagesToSystemConsoleEnabled, Bool, bool, false) \
     macro(IgnoreViewportScalingConstraints, ignoreViewportScalingConstraints, Bool, bool, false) \