Changeset 179867 in webkit

Timestamp:

Feb 10, 2015 12:24:53 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Use a variable to set flicking time instead of hardcoding
​https://bugs.webkit.org/show_bug.cgi?id=138950

Patch by Sanghyup Lee <​sh53.lee@samsung.com> on 2015-02-10
Reviewed by Gyuyoung Kim.

Currently time of flick gesture animation is hardcoded as one second.
This patch added a static variable to increase readability.

• UIProcess/API/efl/GestureRecognizer.cpp:

(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::flickAnimatorCallback):
(WebKit::GestureHandler::handleFlick):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/GestureRecognizer.cpp (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-02-10  Sanghyup Lee  <sh53.lee@samsung.com>
+
+        [EFL] Use a variable to set flicking time instead of hardcoding
+        https://bugs.webkit.org/show_bug.cgi?id=138950
+
+        Reviewed by Gyuyoung Kim.
+
+        Currently time of flick gesture animation is hardcoded as one second.
+        This patch added a static variable to increase readability.
+
+        * UIProcess/API/efl/GestureRecognizer.cpp:
+        (WebKit::GestureHandler::GestureHandler):
+        (WebKit::GestureHandler::flickAnimatorCallback):
+        (WebKit::GestureHandler::handleFlick):
+
 2015-02-09  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp

@@ -64 +64 @@
 
     static const int s_historyCapacity = 5;
+    static constexpr float s_flickTime = 1.0;
 
     EwkView* m_ewkView;
@@ -233 +234 @@
 {
     GestureHandler* gestureHandler = static_cast<GestureHandler*>(data);
-    float multiplier = easeInOutQuad(gestureHandler->m_flickIndex, 0, 1.0, gestureHandler->m_flickDuration);
+    float multiplier = easeInOutQuad(gestureHandler->m_flickIndex, 0, s_flickTime, gestureHandler->m_flickDuration);
     float offsetWidth = gestureHandler->m_flickOffset.width() * multiplier;
     float offsetHeight = gestureHandler->m_flickOffset.height() * multiplier;
@@ -252 +253 @@
 {
     m_flickOffset = offset;
-    m_flickIndex = m_flickDuration = 1 / ecore_animator_frametime_get();
+    m_flickIndex = m_flickDuration = s_flickTime / ecore_animator_frametime_get();
     m_flickAnimator = ecore_animator_add(flickAnimatorCallback, this);
 }