Changeset 179880 in webkit
- Timestamp:
- Feb 10, 2015 1:44:01 PM (9 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r179877 r179880 1 2015-02-10 Chris Dumez <cdumez@apple.com> 2 3 Add assertion to help track down WebCore::DocumentLoader::stopLoadingForPolicyChange() crash 4 https://bugs.webkit.org/show_bug.cgi?id=141441 5 <rdar://problem/13811738> 6 7 Reviewed by Alexey Proskuryakov. 8 9 Add assertion to help track down a crash in 10 WebCore::DocumentLoader::stopLoadingForPolicyChange(). 11 12 * loader/DocumentLoader.cpp: 13 (WebCore::DocumentLoader::~DocumentLoader): 14 Make sure the DocumentLoader is not waiting for a content policy 15 response when it is destroyed. If this were to happen, then the 16 lambda function passed to PolicyChecker::checkContentPolicy() 17 would outlive the DocumentLoader. This is an issue because 18 that lambda function captures [this], which is the DocumentLoader. 19 This would cause DocumentLoader::continueAfterContentPolicy() to 20 be called after the DocumentLoader has been destroyed, which would 21 explain the crash. 22 1 23 2015-02-07 Zalan Bujtas <zalan@apple.com> 2 24 -
trunk/Source/WebCore/loader/DocumentLoader.cpp
r179489 r179880 162 162 { 163 163 ASSERT(!m_frame || frameLoader()->activeDocumentLoader() != this || !isLoading()); 164 ASSERT(!m_waitingForContentPolicy); 164 165 if (m_iconLoadDecisionCallback) 165 166 m_iconLoadDecisionCallback->invalidate();
Note: See TracChangeset
for help on using the changeset viewer.