Changeset 180018 in webkit

Timestamp:

Feb 12, 2015 3:09:05 PM (9 years ago)

Author:

Beth Dakin

Message:

REGRESSION: Should not send wheel events with a delta of 0
​https://bugs.webkit.org/show_bug.cgi?id=141537
-and corresponding-
rdar://problem/18903118

Reviewed by Simon Fraser.

Source/WebCore:

This code should not have been removed entirely to accommodate rubber-banding, it
just needs to return false instead of true in order to allow the MayBegin and
Ended phases to be handled by the ElasticityController.

• dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

LayoutTests:

• platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt (added)
• LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-12  Beth Dakin  <bdakin@apple.com>
+
+        REGRESSION: Should not send wheel events with a delta of 0
+        https://bugs.webkit.org/show_bug.cgi?id=141537
+        -and corresponding-
+        rdar://problem/18903118
+
+        Reviewed by Simon Fraser.
+
+        * platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt: Added.
+        * platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html: Added.
+
 2015-02-12  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-12  Beth Dakin  <bdakin@apple.com>
+
+        REGRESSION: Should not send wheel events with a delta of 0
+        https://bugs.webkit.org/show_bug.cgi?id=141537
+        -and corresponding-
+        rdar://problem/18903118
+
+        Reviewed by Simon Fraser.
+
+        This code should not have been removed entirely to accommodate rubber-banding, it 
+        just needs to return false instead of true in order to allow the MayBegin and 
+        Ended phases to be handled by the ElasticityController.
+        * dom/Element.cpp:
+        (WebCore::Element::dispatchWheelEvent):
+
 2015-02-12  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -280 +280 @@
 bool Element::dispatchWheelEvent(const PlatformWheelEvent& event)
 {
+    if (!event.deltaX() && !event.deltaY())
+        return false;
+
     RefPtr<WheelEvent> wheelEvent = WheelEvent::create(event, document().defaultView());
     return EventDispatcher::dispatchEvent(this, wheelEvent) && !wheelEvent->defaultHandled();