Changeset 18011 in webkit
- Timestamp:
- Dec 4, 2006 4:49:16 PM (17 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 11 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r18009 r18011 1 2006-12-04 Kevin McCullough <KMcCullough@apple.com> 2 3 Reviewed by Darin. 4 5 - removed the guards for the "multiple forms submission" issue, which may not be 6 an issue anymore and the guards prevent perfectly legitimate websites from 7 working correctly. 8 9 * bridge/mac/FrameMac.mm: 10 (WebCore::FrameMac::setView): 11 * bridge/mac/WebCoreAXObject.mm: 12 (-[WebCoreAXObject accessibilityPerformAction:]): 13 * bridge/win/FrameWin.cpp: 14 (WebCore::FrameWin::keyPress): 15 * config.h: 16 * loader/FrameLoader.cpp: 17 (WebCore::FrameLoader::submitForm): 18 * loader/FrameLoader.h: 19 * loader/mac/FrameLoaderMac.mm: 20 (WebCore::FrameLoader::receivedMainResourceError): 21 * loader/qt/FrameLoaderQt.cpp: 22 (WebCore::FrameLoader::submitForm): 23 * page/Frame.cpp: 24 (WebCore::Frame::setView): 25 * page/mac/EventHandlerMac.mm: 26 (WebCore::EventHandler::keyEvent): 27 (WebCore::EventHandler::mouseDown): 28 * platform/qt/FrameQt.cpp: 29 (WebCore::FrameQt::keyEvent): 30 1 31 2006-12-02 Geoffrey Garen <ggaren@apple.com> 2 32 -
trunk/WebCore/bridge/mac/FrameMac.mm
r17987 r18011 356 356 Frame::setView(view); 357 357 358 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 358 359 // Only one form submission is allowed per view of a part. 359 360 // Since this part may be getting reused as a result of being 360 361 // pulled from the back/forward cache, reset this flag. 361 362 loader()->resetMultipleFormSubmissionProtection(); 363 #endif 362 364 } 363 365 -
trunk/WebCore/bridge/mac/WebCoreAXObject.mm
r17958 r18011 886 886 if (!actionElement) 887 887 return; 888 888 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 889 889 if (Frame* f = actionElement->document()->frame()) 890 890 f->loader()->resetMultipleFormSubmissionProtection(); 891 891 #endif 892 892 actionElement->accessKeyAction(true); 893 893 } -
trunk/WebCore/bridge/win/FrameWin.cpp
r18000 r18011 104 104 } 105 105 106 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 106 107 if (!keyEvent.isKeyUp()) 107 108 loader()->resetMultipleFormSubmissionProtection(); 109 #endif 108 110 109 111 result = !EventTargetNodeCast(node)->dispatchKeyEvent(keyEvent); -
trunk/WebCore/loader/FrameLoader.cpp
r17976 r18011 1419 1419 } 1420 1420 1421 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 1421 1422 void FrameLoader::didNotOpenURL(const KURL& URL) 1422 1423 { … … 1429 1430 m_submittedFormURL = KURL(); 1430 1431 } 1432 #endif 1431 1433 1432 1434 void FrameLoader::setEncoding(const String& name, bool userChosen) … … 2172 2174 void FrameLoader::submitForm(const FrameLoadRequest& request, Event* event) 2173 2175 { 2176 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 2174 2177 // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way. 2175 2178 // We do not want to submit more than one form from the same page, … … 2188 2191 m_submittedFormURL = request.resourceRequest().url(); 2189 2192 } 2193 #endif 2190 2194 2191 2195 // FIXME: Why do we always pass true for userGesture? -
trunk/WebCore/loader/FrameLoader.h
r17945 r18011 420 420 bool userGestureHint(); 421 421 422 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 422 423 void resetMultipleFormSubmissionProtection(); 423 424 void didNotOpenURL(const KURL&); 425 #endif 424 426 425 427 void addData(const char* bytes, int length); … … 637 639 RefPtr<HTMLFormElement> m_formAboutToBeSubmitted; 638 640 HashMap<String, String> m_formValuesAboutToBeSubmitted; 641 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 639 642 KURL m_submittedFormURL; 643 #endif 640 644 641 645 Timer<FrameLoader> m_redirectionTimer; -
trunk/WebCore/loader/mac/FrameLoaderMac.mm
r17976 r18011 403 403 404 404 if (m_state == FrameStateProvisional) { 405 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 405 406 NSURL *failedURL = [m_provisionalDocumentLoader->originalRequestCopy() URL]; 406 407 didNotOpenURL(failedURL); 407 408 #endif 408 409 // We might have made a page cache item, but now we're bailing out due to an error before we ever 409 410 // transitioned to the new page (before WebFrameState == commit). The goal here is to restore any state -
trunk/WebCore/loader/qt/FrameLoaderQt.cpp
r17766 r18011 77 77 void FrameLoader::submitForm(const FrameLoadRequest& frameLoadRequest, Event*) 78 78 { 79 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 79 80 // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way. 80 81 // We do not want to submit more than one form from the same page, … … 93 94 m_submittedFormURL = frameLoadRequest.resourceRequest().url(); 94 95 } 96 #endif 95 97 96 98 RefPtr<FormData> formData = frameLoadRequest.resourceRequest().httpBody(); -
trunk/WebCore/page/Frame.cpp
r17958 r18011 242 242 243 243 d->m_view = view; 244 245 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 246 // Only one form submission is allowed per view of a part. 247 // Since this part may be getting reused as a result of being 248 // pulled from the back/forward cache, reset this flag. 249 loader()->resetMultipleFormSubmissionProtection(); 250 #endif 244 251 } 245 252 -
trunk/WebCore/page/mac/EventHandlerMac.mm
r18007 r18011 307 307 return false; 308 308 } 309 309 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 310 310 if ([event type] == NSKeyDown) 311 311 m_frame->loader()->resetMultipleFormSubmissionProtection(); 312 #endif 312 313 313 314 NSEvent *oldCurrentEvent = currentEvent; … … 799 800 800 801 BEGIN_BLOCK_OBJC_EXCEPTIONS; 801 802 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 802 803 m_frame->loader()->resetMultipleFormSubmissionProtection(); 803 804 #endif 804 805 m_mouseDownView = nil; 805 806 dragState().m_dragSrc = 0; -
trunk/WebCore/platform/qt/FrameQt.cpp
r17983 r18011 435 435 } 436 436 437 #ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION 437 438 if (!keyEvent.isKeyUp()) 438 439 loader()->resetMultipleFormSubmissionProtection(); 440 #endif 439 441 440 442 result = !EventTargetNodeCast(node)->dispatchKeyEvent(keyEvent);
Note: See TracChangeset
for help on using the changeset viewer.