Changeset 180239 in webkit

Timestamp:

Feb 17, 2015 2:30:07 PM (9 years ago)

Author:

dbates@webkit.org

Message:

[iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
​https://bugs.webkit.org/show_bug.cgi?id=141718

Reviewed by Alex Christensen.

We should only run layout tests if simctl can successfully boot and shutdown the testing device.

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
Log a error and return False if we are unable to boot the simulator device so that the caller can take
appropriate action, say exit(3) before running any layout tests.

• Scripts/webkitpy/xcode/simulator.py:

(Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
with the specified UDID.
(Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
with the specified UDID can successfully boot and shut down. We make at most two attempts to
boot and shut down the device, erasing the device between tries so as to restore the device
to a known good state.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/ios.py (modified) (1 diff)
• Scripts/webkitpy/xcode/simulator.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-02-17  Daniel Bates  <dabates@apple.com>
+
+        [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
+        https://bugs.webkit.org/show_bug.cgi?id=141718
+
+        Reviewed by Alex Christensen.
+
+        We should only run layout tests if simctl can successfully boot and shutdown the testing device.
+
+        * Scripts/webkitpy/port/ios.py:
+        (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
+        Log a error and return False if we are unable to boot the simulator device so that the caller can take
+        appropriate action, say exit(3) before running any layout tests.
+        * Scripts/webkitpy/xcode/simulator.py:
+        (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
+        with the specified UDID.
+        (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
+        with the specified UDID can successfully boot and shut down. We make at most two attempts to
+        boot and shut down the device, erasing the device between tries so as to restore the device
+        to a known good state.
+
 2015-02-17  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/ios.py

@@ -240 +240 @@
             _log.error('The iOS Simulator runtime with identifier "{0}" cannot be used because it is unavailable.'.format(self.simulator_runtime.identifier))
             return False
+        testing_device = self.testing_device  # May create a new simulator device
+        if not Simulator.check_simulator_device_and_erase_if_needed(self.host, testing_device.udid):
+            _log.error('Unable to boot the simulator device with UDID {0}.'.format(testing_device.udid))
+            return False
         return super(IOSSimulatorPort, self).check_sys_deps(needs_http)
 

trunk/Tools/Scripts/webkitpy/xcode/simulator.py

@@ -278 +278 @@
         return os.path.realpath(os.path.expanduser(os.path.join('~/Library/Developer/CoreSimulator/Devices', udid)))
 
+    @staticmethod
+    def _boot_and_shutdown_simulator_device(host, udid):
+        exit_code = host.executive.run_command(['xcrun', 'simctl', 'boot', udid], return_exit_code=True)
+        if exit_code:
+            return exit_code
+        exit_code = host.executive.run_command(['xcrun', 'simctl', 'shutdown', udid], return_exit_code=True)
+        return exit_code
+
+    @staticmethod
+    def check_simulator_device_and_erase_if_needed(host, udid):
+        exit_code = Simulator._boot_and_shutdown_simulator_device(host, udid)
+        if not exit_code:
+            return True  # Can boot device
+        # Try erasing the simulator device to restore it to a known good state.
+        if not host.executive.run_command(['xcrun', 'simctl', 'erase', udid], return_exit_code=True):
+            return Simulator._boot_and_shutdown_simulator_device(host, udid) == 0  # Can boot device
+        return False  # Cannot boot or erase device
+
     def refresh(self):
         """