Changeset 180501 in webkit

Timestamp:

Feb 23, 2015 7:21:59 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[WinCairo] Crash when media player is destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=141248

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-02-23
Reviewed by Darin Adler.

A COM smart pointer is both released, and set to null.
This means that the COM Release method is called twice, causing a crash.

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::endSession):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-23  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Crash when media player is destroyed.
+        https://bugs.webkit.org/show_bug.cgi?id=141248
+
+        Reviewed by Darin Adler.
+
+        A COM smart pointer is both released, and set to null.
+        This means that the COM Release method is called twice, causing a crash.
+
+        * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+        (WebCore::MediaPlayerPrivateMediaFoundation::endSession):
+
 2015-02-23  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp

@@ -242 +242 @@
     if (m_mediaSession) {
         m_mediaSession->Shutdown();
-        m_mediaSession->Release();
         m_mediaSession = nullptr;
     }