Changeset 180524 in webkit


Ignore:
Timestamp:
Feb 23, 2015 3:06:32 PM (9 years ago)
Author:
ap@apple.com
Message:

Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
https://bugs.webkit.org/show_bug.cgi?id=141925

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._presentPopoverForRevisionRange):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js

    r180504 r180524  
    192192        // FIXME: Nothing guarantees that Trac has historical data for these revisions.
    193193        var linesForCommits = this._popoverLinesForCommitRange(context.trac, context.branch, context.firstRevision, context.lastRevision);
    194         if (!linesForCommits.length)
    195             return false;
    196194
    197195        var line = document.createElement("div");
    198196        line.className = "title";
    199         line.textContent = "commits since previous result";
    200         content.appendChild(line);
    201         this._addDividerToPopover(content);
     197
     198        if (linesForCommits.length) {
     199            line.textContent = "commits since previous result";
     200            content.appendChild(line);
     201            this._addDividerToPopover(content);
     202        } else {
     203            line.textContent = "no commits to " + context.branch + " since previous result";
     204            content.appendChild(line);
     205        }
    202206
    203207        for (var i = 0; i != linesForCommits.length; ++i)
  • trunk/Tools/ChangeLog

    r180519 r180524  
     12015-02-23  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
     4        https://bugs.webkit.org/show_bug.cgi?id=141925
     5
     6        Reviewed by Tim Horton.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
     9        (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
     10
    1112015-02-23  Anders Carlsson  <andersca@apple.com>
    212
Note: See TracChangeset for help on using the changeset viewer.