Changeset 180721 in webkit

Timestamp:

Feb 26, 2015 8:08:24 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Clear Log on Reload clears some logs that were after reload
​https://bugs.webkit.org/show_bug.cgi?id=142070

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-26
Reviewed by Timothy Hatcher.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._sessionStarted):
We can bail after calling clearLog, since that will already start
a new session for us.

(WebInspector.LogContentView.prototype._clearLog):
Don't trigger a backend clear messages, since that will cause us to
clear messages received between the request and response.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-02-26  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Clear Log on Reload clears some logs that were after reload
+        https://bugs.webkit.org/show_bug.cgi?id=142070
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/LogContentView.js:
+        (WebInspector.LogContentView.prototype._sessionStarted):
+        We can bail after calling clearLog, since that will already start
+        a new session for us.
+
+        (WebInspector.LogContentView.prototype._clearLog):
+        Don't trigger a backend clear messages, since that will cause us to
+        clear messages received between the request and response.
+
 2015-02-26  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -304 +304 @@
     _sessionStarted: function(event)
     {
-        if (this._clearLogOnReloadSetting.value) 
+        if (this._clearLogOnReloadSetting.value)  {
             this._clearLog();
+            return;
+        }
 
         this._logViewController.startNewSession();
@@ -639 +641 @@
     _clearLog: function()
     {
+        this._ignoreDidClearMessages = true;
         this._logViewController.clear();
+        this._ignoreDidClearMessages = false;
     },