Changeset 180937 in webkit

Timestamp:

Mar 3, 2015 9:13:23 AM (9 years ago)

Author:

Brian Burg

Message:

Web Inspector: popover should use requestAnimationFrame to drive move/resize animations
​https://bugs.webkit.org/show_bug.cgi?id=142218

Reviewed by Timothy Hatcher.

Remove setTimeout workaround now that Inspector runs in its own process.

• UserInterface/Views/Popover.js:

(WebInspector.Popover.prototype.drawBackground):
(WebInspector.Popover.prototype._animateFrame):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/Popover.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-03-03  Brian J. Burg  <burg@cs.washington.edu>
+
+        Web Inspector: popover should use requestAnimationFrame to drive move/resize animations
+        https://bugs.webkit.org/show_bug.cgi?id=142218
+
+        Reviewed by Timothy Hatcher.
+
+        Remove setTimeout workaround now that Inspector runs in its own process.
+
+        * UserInterface/Views/Popover.js:
+        (WebInspector.Popover.prototype.drawBackground):
+        (WebInspector.Popover.prototype._animateFrame):
+
 2015-03-03  Brian J. Burg  <burg@cs.washington.edu>
 

trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js

@@ -354 +354 @@
             this._drawBackground();
 
-            if (progress < 1) {
-                // FIXME: Revert to using window.requestAnimationFrame when Inspector is out of process.
-                // It can't currently use window.requestAnimationFrame because the callback passed into
-                // it won't fire while paused in the debugger inside the Inspector.
-                const animationRate60FPS = 17;
-                setTimeout(drawBackground.bind(this), animationRate60FPS);
-            }
+            if (progress < 1)
+                requestAnimationFrame(drawBackground.bind(this));
         }