Changeset 181038 in webkit

Timestamp:

Mar 4, 2015 3:18:36 PM (9 years ago)

Author:

dino@apple.com

Message:

REGRESSION (r179597): Can't see power saver banner for plugins
​https://bugs.webkit.org/show_bug.cgi?id=142312
<rdar://problem/20040517>

Reviewed by Brent Fulgham.

We were being a bit too restrictive when deciding a child
should not create a renderer. All shadow root children
of the snapshotted plugin need one.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::childShouldCreateRenderer):
Test if we're part of the shadow tree.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLPlugInImageElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-04  Dean Jackson  <dino@apple.com>
+
+        REGRESSION (r179597): Can't see power saver banner for plugins
+        https://bugs.webkit.org/show_bug.cgi?id=142312
+        <rdar://problem/20040517>
+
+        Reviewed by Brent Fulgham.
+
+        We were being a bit too restrictive when deciding a child
+        should not create a renderer. All shadow root children
+        of the snapshotted plugin need one.
+
+        * html/HTMLPlugInImageElement.cpp:
+        (WebCore::HTMLPlugInImageElement::childShouldCreateRenderer):
+        Test if we're part of the shadow tree.
+
 2015-03-03  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp

@@ -224 +224 @@
 bool HTMLPlugInImageElement::childShouldCreateRenderer(const Node& child) const
 {
-    if (is<RenderSnapshottedPlugIn>(renderer()) && !partOfSnapshotOverlay(&child))
+    if (is<RenderSnapshottedPlugIn>(renderer()) && !hasShadowRootParent(child))
         return false;