Changeset 181080 in webkit

Timestamp:

Mar 5, 2015 9:06:15 AM (9 years ago)

Author:

Antti Koivisto

Message:

Support WorkQueue QOS classes on Mavericks
​https://bugs.webkit.org/show_bug.cgi?id=142328

Reviewed by Anders Carlsson.

"The priority of a dispatch queue is inherited from its target queue. In order to
change the priority of a queue created with dispatch_queue_create(), use the
dispatch_get_global_queue() function to obtain a target queue of the desired prior-
ity."

• wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::targetQueueForQOSClass):
(WTF::WorkQueue::platformInitialize):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/cocoa/WorkQueueCocoa.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2015-03-05  Antti Koivisto  <antti@apple.com>
+
+        Support WorkQueue QOS classes on Mavericks
+        https://bugs.webkit.org/show_bug.cgi?id=142328
+
+        Reviewed by Anders Carlsson.
+
+        "The priority of a dispatch queue is inherited from its target queue.  In order to
+        change the priority of a queue created with dispatch_queue_create(), use the
+        dispatch_get_global_queue() function to obtain a target queue of the desired prior-
+        ity."
+
+        * wtf/cocoa/WorkQueueCocoa.cpp:
+        (WTF::targetQueueForQOSClass):
+        (WTF::WorkQueue::platformInitialize):
+
 2015-03-03  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp

@@ -63 +63 @@
     }
 }
+#else
+static dispatch_queue_t targetQueueForQOSClass(WorkQueue::QOS qos)
+{
+    switch (qos) {
+    case WorkQueue::QOS::UserInteractive:
+    case WorkQueue::QOS::UserInitiated:
+        return dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0);
+    case WorkQueue::QOS::Utility:
+        return dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_LOW, 0);
+    case WorkQueue::QOS::Background:
+        return dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0);
+    case WorkQueue::QOS::Default:
+        ASSERT_NOT_REACHED();
+        return nullptr;
+    }
+    ASSERT_NOT_REACHED();
+}
 #endif
 
@@ -74 +91 @@
 #endif
     m_dispatchQueue = dispatch_queue_create(name, attr);
+#if !HAVE(QOS_CLASSES)
+    if (qos != WorkQueue::QOS::Default)
+        dispatch_set_target_queue(m_dispatchQueue, targetQueueForQOSClass(qos));
+#endif
     dispatch_set_context(m_dispatchQueue, this);
 }