Changeset 181098 in webkit

Timestamp:

Mar 5, 2015 1:38:14 PM (9 years ago)

Author:

Brent Fulgham

Message:

[Win] Ensure build target directory exists when launching MSBuild
​https://bugs.webkit.org/show_bug.cgi?id=142360

Reviewed by Dean Jackson.

Create the build output directory (if it doesn't exist) before
launching MSBuild so that it can immediately begin writing logs.

• Scripts/webkitdirs.pm:

(buildVisualStudioProject):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitdirs.pm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-03-05  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] Ensure build target directory exists when launching MSBuild
+        https://bugs.webkit.org/show_bug.cgi?id=142360
+
+        Reviewed by Dean Jackson.
+
+        Create the build output directory (if it doesn't exist) before
+        launching MSBuild so that it can immediately begin writing logs.
+
+        * Scripts/webkitdirs.pm:
+        (buildVisualStudioProject):
+
 2015-03-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -39 +39 @@
 use File::Basename;
 use File::Find;
-use File::Path qw(mkpath rmtree);
+use File::Path qw(make_path mkpath rmtree);
 use File::Spec;
 use File::stat;
@@ -1685 +1685 @@
 
     my $platform = "/p:Platform=" . (isWin64() ? "x64" : "Win32");
-    my $logFile = File::Spec->catdir($baseProductDir, $configuration, "BuildOutput.htm");
+    my $logPath = File::Spec->catdir($baseProductDir, $configuration);
+    File::Path->make_path($logPath) unless -d $logPath;
+
+    my $logFile = File::Spec->catfile($logPath, "BuildOutput.htm");
     chomp($logFile = `cygpath -w "$logFile"`) if isCygwin();
     my $logging = "/flp:LogFile=" . $logFile . ";Verbosity=minimal";
-    
+
     my @command = ($vcBuildPath, "/verbosity:minimal", $project, $action, $config, $platform, "/fl", $logging);