Changeset 181167 in webkit

Timestamp:

Mar 6, 2015 10:21:36 AM (9 years ago)

Author:

mmaxfield@apple.com

Message:

Test horiz-origin-x and horiz-origin-y in SVG fonts
​https://bugs.webkit.org/show_bug.cgi?id=142403

Source/WebCore:

Reviewed by Simon Fraser.

Remove incorrect comment.

Test: svg/fonts/svg-font-horiz-origin.html

• svg/SVGToOTFFontConversion.cpp:

(WebCore::CFFBuilder::CFFBuilder):

LayoutTests:

Simply moving to the origin in glyph-space at the beginning
of path parsing won't work if subsequent coordinates are absolute.

Reviewed by Simon Fraser.

• svg/fonts/resources/svg-font-horiz-origin-font.svg: Added.
• svg/fonts/svg-font-horiz-origin-expected.html: Added.
• svg/fonts/svg-font-horiz-origin.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/fonts (added)
• LayoutTests/svg/fonts/resources (added)
• LayoutTests/svg/fonts/resources/svg-font-horiz-origin-font.svg (added)
• LayoutTests/svg/fonts/svg-font-horiz-origin-expected.html (added)
• LayoutTests/svg/fonts/svg-font-horiz-origin.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGToOTFFontConversion.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Test horiz-origin-x and horiz-origin-y in SVG fonts
+        https://bugs.webkit.org/show_bug.cgi?id=142403
+
+        Simply moving to the origin in glyph-space at the beginning
+        of path parsing won't work if subsequent coordinates are absolute.
+
+        Reviewed by Simon Fraser.
+
+        * svg/fonts/resources/svg-font-horiz-origin-font.svg: Added.
+        * svg/fonts/svg-font-horiz-origin-expected.html: Added.
+        * svg/fonts/svg-font-horiz-origin.html: Added.
+
 2015-03-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Test horiz-origin-x and horiz-origin-y in SVG fonts
+        https://bugs.webkit.org/show_bug.cgi?id=142403
+
+        Reviewed by Simon Fraser.
+
+        Remove incorrect comment.
+
+        Test: svg/fonts/svg-font-horiz-origin.html
+
+        * svg/SVGToOTFFontConversion.cpp:
+        (WebCore::CFFBuilder::CFFBuilder):
+
 2015-03-06  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp

@@ -1052 +1052 @@
         , m_hasBoundingBox(false)
     {
-        // FIXME: Moving to the origin isn't going to work for subsequent absolute coordinates
         writeCFFEncodedNumber(m_cffData, width);
         writeCFFEncodedNumber(m_cffData, origin.x());