Changeset 181217 in webkit


Ignore:
Timestamp:
Mar 7, 2015 6:14:22 PM (9 years ago)
Author:
Darin Adler
Message:

Improve the event handler test
​https://bugs.webkit.org/show_bug.cgi?id=142439

Reviewed by Ryosuke Niwa.

  • fast/dom/event-handler-attributes-expected.txt: Renamed from legacy-event-handler-attributes-expected.txt.

Also updated to reflect changes in the test.

  • fast/dom/event-handler-attributes.html: Renamed from legacy-event-handler-attributes.html.

Fixed bug in the test that was making document event handler tests falsely report failure.
Removed testing of some HTMLMediaElement attributes that are conditionally present; this test
is intended to test only unconditionally available event handler attributes at this time.

  • platform/win/fast/dom/legacy-event-handler-attributes-expected.txt: Removed. The conditional HTMLMediaElement

attributes are the reason the Windows-specific results were needed.

Location:
trunk/LayoutTests
Files:
1 deleted
1 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r181204 r181217  
     12015-03-07  Darin Adler  <darin@apple.com>
     2
     3        Improve the event handler test
     4        https://bugs.webkit.org/show_bug.cgi?id=142439
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * fast/dom/event-handler-attributes-expected.txt: Renamed from legacy-event-handler-attributes-expected.txt.
     9        Also updated to reflect changes in the test.
     10
     11        * fast/dom/event-handler-attributes.html: Renamed from legacy-event-handler-attributes.html.
     12        Fixed bug in the test that was making document event handler tests falsely report failure.
     13        Removed testing of some HTMLMediaElement attributes that are conditionally present; this test
     14        is intended to test only unconditionally available event handler attributes at this time.
     15
     16        * platform/win/fast/dom/legacy-event-handler-attributes-expected.txt: Removed. The conditional HTMLMediaElement
     17        attributes are the reason the Windows-specific results were needed.
     18
    1192015-03-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    220

  • trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt

    r181216 r181217  
    1 Test which event listeners are set up by legacy event handler attributes (the ones with names like onclick).
     1Test which event listeners are set up by event handler attributes (the ones with names like onclick).
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    … …  
    9999PASS testScriptAttribute(window, "touchmove") is "none"
    100100PASS testScriptAttribute(window, "touchstart") is "none"
    101 PASS testScriptAttribute(window, "webkitkeyadded") is "none"
    102 PASS testScriptAttribute(window, "webkitkeyerror") is "none"
    103 PASS testScriptAttribute(window, "webkitkeymessage") is "none"
    104101PASS testScriptAttribute(window, "webkitpresentationmodechanged") is "none"
    105102
    106103Event names we expect to be able to set on the document
    107104
    108 FAIL testScriptAttribute(document, "abort") should be document. Was document, remove failed.
    109 FAIL testScriptAttribute(document, "beforecopy") should be document. Was document, remove failed.
    110 FAIL testScriptAttribute(document, "beforecut") should be document. Was document, remove failed.
    111 FAIL testScriptAttribute(document, "beforepaste") should be document. Was document, remove failed.
    112 FAIL testScriptAttribute(document, "blur") should be document. Was document, remove failed.
    113 FAIL testScriptAttribute(document, "change") should be document. Was document, remove failed.
    114 FAIL testScriptAttribute(document, "click") should be document. Was document, remove failed.
    115 FAIL testScriptAttribute(document, "contextmenu") should be document. Was document, remove failed.
    116 FAIL testScriptAttribute(document, "copy") should be document. Was document, remove failed.
    117 FAIL testScriptAttribute(document, "cut") should be document. Was document, remove failed.
    118 FAIL testScriptAttribute(document, "dblclick") should be document. Was document, remove failed.
    119 FAIL testScriptAttribute(document, "drag") should be document. Was document, remove failed.
    120 FAIL testScriptAttribute(document, "dragend") should be document. Was document, remove failed.
    121 FAIL testScriptAttribute(document, "dragenter") should be document. Was document, remove failed.
    122 FAIL testScriptAttribute(document, "dragleave") should be document. Was document, remove failed.
    123 FAIL testScriptAttribute(document, "dragover") should be document. Was document, remove failed.
    124 FAIL testScriptAttribute(document, "dragstart") should be document. Was document, remove failed.
    125 FAIL testScriptAttribute(document, "drop") should be document. Was document, remove failed.
    126 FAIL testScriptAttribute(document, "error") should be document. Was document, remove failed.
    127 FAIL testScriptAttribute(document, "focus") should be document. Was document, remove failed.
    128 FAIL testScriptAttribute(document, "input") should be document. Was document, remove failed.
    129 FAIL testScriptAttribute(document, "invalid") should be document. Was document, remove failed.
    130 FAIL testScriptAttribute(document, "keydown") should be document. Was document, remove failed.
    131 FAIL testScriptAttribute(document, "keypress") should be document. Was document, remove failed.
    132 FAIL testScriptAttribute(document, "keyup") should be document. Was document, remove failed.
    133 FAIL testScriptAttribute(document, "load") should be document. Was document, remove failed.
    134 FAIL testScriptAttribute(document, "mousedown") should be document. Was document, remove failed.
    135 FAIL testScriptAttribute(document, "mouseenter") should be document. Was document, remove failed.
    136 FAIL testScriptAttribute(document, "mouseleave") should be document. Was document, remove failed.
    137 FAIL testScriptAttribute(document, "mousemove") should be document. Was document, remove failed.
    138 FAIL testScriptAttribute(document, "mouseout") should be document. Was document, remove failed.
    139 FAIL testScriptAttribute(document, "mouseover") should be document. Was document, remove failed.
    140 FAIL testScriptAttribute(document, "mouseup") should be document. Was document, remove failed.
    141 FAIL testScriptAttribute(document, "mousewheel") should be document. Was document, remove failed.
    142 FAIL testScriptAttribute(document, "paste") should be document. Was document, remove failed.
    143 FAIL testScriptAttribute(document, "readystatechange") should be document. Was document, remove failed.
    144 FAIL testScriptAttribute(document, "reset") should be document. Was document, remove failed.
    145 FAIL testScriptAttribute(document, "scroll") should be document. Was document, remove failed.
    146 FAIL testScriptAttribute(document, "search") should be document. Was document, remove failed.
    147 FAIL testScriptAttribute(document, "select") should be document. Was document, remove failed.
    148 FAIL testScriptAttribute(document, "selectionchange") should be document. Was document, remove failed.
    149 FAIL testScriptAttribute(document, "selectstart") should be document. Was document, remove failed.
    150 FAIL testScriptAttribute(document, "submit") should be document. Was document, remove failed.
    151 FAIL testScriptAttribute(document, "wheel") should be document. Was document, remove failed.
     105PASS testScriptAttribute(document, "abort") is "document"
     106PASS testScriptAttribute(document, "beforecopy") is "document"
     107PASS testScriptAttribute(document, "beforecut") is "document"
     108PASS testScriptAttribute(document, "beforepaste") is "document"
     109PASS testScriptAttribute(document, "blur") is "document"
     110PASS testScriptAttribute(document, "change") is "document"
     111PASS testScriptAttribute(document, "click") is "document"
     112PASS testScriptAttribute(document, "contextmenu") is "document"
     113PASS testScriptAttribute(document, "copy") is "document"
     114PASS testScriptAttribute(document, "cut") is "document"
     115PASS testScriptAttribute(document, "dblclick") is "document"
     116PASS testScriptAttribute(document, "drag") is "document"
     117PASS testScriptAttribute(document, "dragend") is "document"
     118PASS testScriptAttribute(document, "dragenter") is "document"
     119PASS testScriptAttribute(document, "dragleave") is "document"
     120PASS testScriptAttribute(document, "dragover") is "document"
     121PASS testScriptAttribute(document, "dragstart") is "document"
     122PASS testScriptAttribute(document, "drop") is "document"
     123PASS testScriptAttribute(document, "error") is "document"
     124PASS testScriptAttribute(document, "focus") is "document"
     125PASS testScriptAttribute(document, "input") is "document"
     126PASS testScriptAttribute(document, "invalid") is "document"
     127PASS testScriptAttribute(document, "keydown") is "document"
     128PASS testScriptAttribute(document, "keypress") is "document"
     129PASS testScriptAttribute(document, "keyup") is "document"
     130PASS testScriptAttribute(document, "load") is "document"
     131PASS testScriptAttribute(document, "mousedown") is "document"
     132PASS testScriptAttribute(document, "mouseenter") is "document"
     133PASS testScriptAttribute(document, "mouseleave") is "document"
     134PASS testScriptAttribute(document, "mousemove") is "document"
     135PASS testScriptAttribute(document, "mouseout") is "document"
     136PASS testScriptAttribute(document, "mouseover") is "document"
     137PASS testScriptAttribute(document, "mouseup") is "document"
     138PASS testScriptAttribute(document, "mousewheel") is "document"
     139PASS testScriptAttribute(document, "paste") is "document"
     140PASS testScriptAttribute(document, "readystatechange") is "document"
     141PASS testScriptAttribute(document, "reset") is "document"
     142PASS testScriptAttribute(document, "scroll") is "document"
     143PASS testScriptAttribute(document, "search") is "document"
     144PASS testScriptAttribute(document, "select") is "document"
     145PASS testScriptAttribute(document, "selectionchange") is "document"
     146PASS testScriptAttribute(document, "selectstart") is "document"
     147PASS testScriptAttribute(document, "submit") is "document"
     148PASS testScriptAttribute(document, "wheel") is "document"
    152149
    153150Event names we expect not to be able to set on the document
    … …  
    198195PASS testScriptAttribute(document, "webkitanimationiteration") is "none"
    199196PASS testScriptAttribute(document, "webkitanimationstart") is "none"
    200 PASS testScriptAttribute(document, "webkitkeyadded") is "none"
    201 PASS testScriptAttribute(document, "webkitkeyerror") is "none"
    202 PASS testScriptAttribute(document, "webkitkeymessage") is "none"
    203197PASS testScriptAttribute(document, "webkitpresentationmodechanged") is "none"
    204198PASS testScriptAttribute(document, "webkittransitionend") is "none"
    … …  
    280274FAIL testElementAttribute(element, "webkitanimationiteration") should be target. Was script: none; content: target.
    281275FAIL testElementAttribute(element, "webkitanimationstart") should be target. Was script: none; content: target.
    282 FAIL testElementAttribute(element, "webkitkeyadded") should be target. Was none.
    283 FAIL testElementAttribute(element, "webkitkeyerror") should be target. Was none.
    284 FAIL testElementAttribute(element, "webkitkeymessage") should be target. Was none.
    285276FAIL testElementAttribute(element, "webkitpresentationmodechanged") should be target. Was none.
    286277FAIL testElementAttribute(element, "webkittransitionend") should be target. Was script: none; content: target.
    … …  
    380371FAIL testElementAttribute(inputElement, "webkitanimationiteration") should be target. Was script: none; content: target.
    381372FAIL testElementAttribute(inputElement, "webkitanimationstart") should be target. Was script: none; content: target.
    382 FAIL testElementAttribute(inputElement, "webkitkeyadded") should be target. Was none.
    383 FAIL testElementAttribute(inputElement, "webkitkeyerror") should be target. Was none.
    384 FAIL testElementAttribute(inputElement, "webkitkeymessage") should be target. Was none.
    385373FAIL testElementAttribute(inputElement, "webkitpresentationmodechanged") should be target. Was none.
    386374FAIL testElementAttribute(inputElement, "webkittransitionend") should be target. Was script: none; content: target.
    … …  
    480468FAIL testElementAttribute(audioElement, "webkitanimationiteration") should be target. Was script: none; content: target.
    481469FAIL testElementAttribute(audioElement, "webkitanimationstart") should be target. Was script: none; content: target.
    482 FAIL testElementAttribute(audioElement, "webkitkeyadded") should be target. Was none.
    483 FAIL testElementAttribute(audioElement, "webkitkeyerror") should be target. Was none.
    484 FAIL testElementAttribute(audioElement, "webkitkeymessage") should be target. Was none.
    485470FAIL testElementAttribute(audioElement, "webkitpresentationmodechanged") should be target. Was none.
    486471FAIL testElementAttribute(audioElement, "webkittransitionend") should be target. Was script: none; content: target.
    … …  
    580565FAIL testElementAttribute(videoElement, "webkitanimationiteration") should be target. Was script: none; content: target.
    581566FAIL testElementAttribute(videoElement, "webkitanimationstart") should be target. Was script: none; content: target.
    582 FAIL testElementAttribute(videoElement, "webkitkeyadded") should be target. Was none.
    583 FAIL testElementAttribute(videoElement, "webkitkeyerror") should be target. Was none.
    584 FAIL testElementAttribute(videoElement, "webkitkeymessage") should be target. Was none.
    585567FAIL testElementAttribute(videoElement, "webkitpresentationmodechanged") should be target. Was none.
    586568FAIL testElementAttribute(videoElement, "webkittransitionend") should be target. Was script: none; content: target.
    … …  
    624606Event names we expect to be forwarded from <body> element to document)
    625607
    626 FAIL testElementAttribute(bodyElement, "selectionchange") should be document. Was script: none; content: document, remove failed.
     608FAIL testElementAttribute(bodyElement, "selectionchange") should be document. Was script: none; content: document.
    627609
    628610Non-forwarded event names on <body> element
    … …  
    698680FAIL testElementAttribute(bodyElement, "webkitanimationiteration") should be target. Was script: none; content: target.
    699681FAIL testElementAttribute(bodyElement, "webkitanimationstart") should be target. Was script: none; content: target.
    700 FAIL testElementAttribute(bodyElement, "webkitkeyadded") should be target. Was none.
    701 FAIL testElementAttribute(bodyElement, "webkitkeyerror") should be target. Was none.
    702 FAIL testElementAttribute(bodyElement, "webkitkeymessage") should be target. Was none.
    703682FAIL testElementAttribute(bodyElement, "webkitpresentationmodechanged") should be target. Was none.
    704683FAIL testElementAttribute(bodyElement, "webkittransitionend") should be target. Was script: none; content: target.
    … …  
    804783FAIL testElementAttribute(framesetElement, "webkitanimationiteration") should be target. Was script: none; content: target.
    805784FAIL testElementAttribute(framesetElement, "webkitanimationstart") should be target. Was script: none; content: target.
    806 FAIL testElementAttribute(framesetElement, "webkitkeyadded") should be target. Was none.
    807 FAIL testElementAttribute(framesetElement, "webkitkeyerror") should be target. Was none.
    808 FAIL testElementAttribute(framesetElement, "webkitkeymessage") should be target. Was none.
    809785FAIL testElementAttribute(framesetElement, "webkitpresentationmodechanged") should be target. Was none.
    810786FAIL testElementAttribute(framesetElement, "webkittransitionend") should be target. Was script: none; content: target.

  • trunk/LayoutTests/fast/dom/event-handler-attributes.html

    r181216 r181217  
    44<script src="../../resources/js-test-pre.js"></script>
    55<script>
    6 description("Test which event listeners are set up by legacy event handler attributes (the ones with names like onclick).");
     6description("Test which event listeners are set up by event handler attributes (the ones with names like onclick).");
    77
    88const unusualEventNames = {
    … …  
    212212    "webkitanimationiteration",
    213213    "webkitanimationstart",
    214     "webkitkeyadded",
    215     "webkitkeyerror",
    216     "webkitkeymessage",
    217214    "webkitpresentationmodechanged",
    218215    "webkittransitionend",
    … …  
    270267    remove();
    271268
     269    sideEffect = capturedMagicNumber - 1;
     270
    272271    object.dispatchEvent(new Event(eventName));
    273272    window.dispatchEvent(new Event(eventName));
    … …  
    463462html/HTMLFormElement.idl:    [Conditional=REQUEST_AUTOCOMPLETE, NotEnumerable] attribute EventListener onautocompleteerror;
    464463
     464html/HTMLMediaElement.idl:    attribute EventListener onwebkitkeyadded;
     465html/HTMLMediaElement.idl:    attribute EventListener onwebkitkeyerror;
     466html/HTMLMediaElement.idl:    attribute EventListener onwebkitkeymessage;
    465467html/HTMLMediaElement.idl:    [Conditional=ENCRYPTED_MEDIA|ENCRYPTED_MEDIA_V2] attribute EventListener onwebkitneedkey;
    466468html/HTMLMediaElement.idl:    [Conditional=WIRELESS_PLAYBACK_TARGET] attribute EventListener onwebkitcurrentplaybacktargetiswirelesschanged;
Note: See TracChangeset for help on using the changeset viewer.