Changeset 181262 in webkit
- Timestamp:
- Mar 9, 2015 4:31:47 AM (9 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r181259 r181262 1 2015-03-09 Xabier Rodriguez Calvar <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr> 2 3 ReadableStream does not not need to pass itself as callback parameter 4 https://bugs.webkit.org/show_bug.cgi?id=142399 5 6 Reviewed by Darin Adler. 7 8 No change in behavior. 9 10 * Modules/streams/ReadableStream.h: Remove ReadableStream parameter from SuccessCallback definition. 11 * bindings/js/JSReadableStreamCustom.cpp: 12 (WebCore::JSReadableStream::ready): Capture JSReadableStream instance instead. 13 (WebCore::JSReadableStream::closed): Capture JSReadableStream instance instead. 14 1 15 2015-03-08 Dean Jackson <dino@apple.com> 2 16 -
trunk/Source/WebCore/Modules/streams/ReadableStream.h
r180801 r181262 62 62 String state() const; 63 63 64 typedef std::function<void( RefPtr<ReadableStream>)> SuccessCallback;64 typedef std::function<void()> SuccessCallback; 65 65 void closed(SuccessCallback); 66 66 void ready(SuccessCallback); -
trunk/Source/WebCore/bindings/js/JSReadableStreamCustom.cpp
r180559 r181262 71 71 JSPromiseDeferred* promiseDeferred = getOrCreatePromiseDeferredFromObject(exec, this, globalObject(), readyPromiseSlotName()); 72 72 DeferredWrapper wrapper(exec, globalObject(), promiseDeferred); 73 auto successCallback = [wrapper ](RefPtr<ReadableStream> stream) mutable {74 wrapper.resolve( stream.get());73 auto successCallback = [wrapper, this]() mutable { 74 wrapper.resolve(&impl()); 75 75 }; 76 76 impl().ready(WTF::move(successCallback)); … … 89 89 JSPromiseDeferred* promiseDeferred = getOrCreatePromiseDeferredFromObject(exec, this, globalObject(), closedPromiseSlotName()); 90 90 DeferredWrapper wrapper(exec, globalObject(), promiseDeferred); 91 auto successCallback = [wrapper ](RefPtr<ReadableStream> stream) mutable {92 wrapper.resolve( stream.get());91 auto successCallback = [wrapper, this]() mutable { 92 wrapper.resolve(&impl()); 93 93 }; 94 94 impl().closed(WTF::move(successCallback));
Note: See TracChangeset
for help on using the changeset viewer.