Changeset 181285 in webkit


Ignore:
Timestamp:
Mar 9, 2015 3:09:34 PM (9 years ago)
Author:
mmaxfield@apple.com
Message:

svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
https://bugs.webkit.org/show_bug.cgi?id=142470

Reviewed by Anders Carlsson.

Source/WebCore:

After each test, reset all internal settings.

Covered by svg/custom/svg-fonts-without-missing-glyph.xhtml

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

LayoutTests:

  • platform/mac/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r181283 r181285  
     12015-03-09  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
     4        https://bugs.webkit.org/show_bug.cgi?id=142470
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * platform/mac/TestExpectations:
     9
    1102015-03-09  Benjamin Poulain  <benjamin@webkit.org>
    211
  • trunk/LayoutTests/platform/mac/TestExpectations

    r181277 r181285  
    12381238webkit.org/b/137098 svg/text/text-hkern.svg [ Failure ]
    12391239webkit.org/b/137100 svg/text/text-vkern.svg [ Failure ]
    1240 webkit.org/b/142470 svg/custom/svg-fonts-without-missing-glyph.xhtml [ Pass Failure ]
    12411240
    12421241# Sometimes has an extra space at the end
  • trunk/Source/WebCore/ChangeLog

    r181284 r181285  
     12015-03-09  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
     4        https://bugs.webkit.org/show_bug.cgi?id=142470
     5
     6        Reviewed by Anders Carlsson.
     7
     8        After each test, reset all internal settings.
     9
     10        Covered by svg/custom/svg-fonts-without-missing-glyph.xhtml
     11
     12        * testing/InternalSettings.cpp:
     13        (WebCore::InternalSettings::Backup::Backup):
     14        (WebCore::InternalSettings::Backup::restoreTo):
     15        * testing/InternalSettings.h:
     16
    1172015-03-09  Commit Queue  <commit-queue@webkit.org>
    218
  • trunk/Source/WebCore/testing/InternalSettings.cpp

    r173682 r181285  
    9191    , m_pluginReplacementEnabled(RuntimeEnabledFeatures::sharedFeatures().pluginReplacementEnabled())
    9292    , m_shouldConvertPositionStyleOnCopy(settings.shouldConvertPositionStyleOnCopy())
     93    , m_fontFallbackPrefersPictographs(settings.fontFallbackPrefersPictographs())
     94    , m_backgroundShouldExtendBeyondPage(settings.backgroundShouldExtendBeyondPage())
     95    , m_storageBlockingPolicy(settings.storageBlockingPolicy())
     96    , m_scrollingTreeIncludesFrames(settings.scrollingTreeIncludesFrames())
     97#if ENABLE(TOUCH_EVENTS)
     98    , m_touchEventEmulationEnabled(settings.isTouchEventEmulationEnabled())
     99#endif
    93100{
    94101}
     
    147154    settings.setAutoscrollForDragAndDropEnabled(m_autoscrollForDragAndDropEnabled);
    148155    settings.setShouldConvertPositionStyleOnCopy(m_shouldConvertPositionStyleOnCopy);
     156    settings.setFontFallbackPrefersPictographs(m_fontFallbackPrefersPictographs);
     157    settings.setBackgroundShouldExtendBeyondPage(m_backgroundShouldExtendBeyondPage);
     158    settings.setStorageBlockingPolicy(m_storageBlockingPolicy);
     159    settings.setScrollingTreeIncludesFrames(m_scrollingTreeIncludesFrames);
     160#if ENABLE(TOUCH_EVENTS)
     161    settings.setTouchEventEmulationEnabled(m_touchEventEmulationEnabled);
     162#endif
    149163    RuntimeEnabledFeatures::sharedFeatures().setPluginReplacementEnabled(m_pluginReplacementEnabled);
    150164}
     
    487501}
    488502
    489 }
     503// If you add to this list, make sure that you update the Backup class for test reproducability!
     504
     505}
  • trunk/Source/WebCore/testing/InternalSettings.h

    r171479 r181285  
    3535#include "IntSize.h"
    3636#include "InternalSettingsGenerated.h"
     37#include "SecurityOrigin.h"
    3738#include <wtf/PassRefPtr.h>
    3839
     
    8889        bool m_pluginReplacementEnabled;
    8990        bool m_shouldConvertPositionStyleOnCopy;
     91        bool m_fontFallbackPrefersPictographs;
     92        bool m_backgroundShouldExtendBeyondPage;
     93        SecurityOrigin::StorageBlockingPolicy m_storageBlockingPolicy;
     94        bool m_scrollingTreeIncludesFrames;
     95#if ENABLE(TOUCH_EVENTS)
     96        bool m_touchEventEmulationEnabled;
     97#endif
    9098    };
    9199
Note: See TracChangeset for help on using the changeset viewer.