Changeset 181334 in webkit


Ignore:
Timestamp:
Mar 10, 2015 12:29:13 PM (9 years ago)
Author:
mark.lam@apple.com
Message:

[Win] JSC Build Warnings Need to be Resolved.
<https://webkit.org/b/142366>

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Applied some benign changes to make the MSVC compiler happy.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):

  • runtime/BasicBlockLocation.cpp:

(JSC::BasicBlockLocation::getExecutedRanges):

  • runtime/ControlFlowProfiler.cpp:

(JSC::ControlFlowProfiler::hasBasicBlockAtTextOffsetBeenExecuted):

Source/WTF:

  • wtf/Compiler.h:
  • MSVC also does not have the CONSIDERS_UNREACHABLE_CODE quirk.
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r181333 r181334  
     12015-03-10  Mark Lam  <mark.lam@apple.com>
     2
     3        [Win] JSC Build Warnings Need to be Resolved.
     4        <https://webkit.org/b/142366>
     5
     6        Reviewed by Brent Fulgham.
     7
     8        Applied some benign changes to make the MSVC compiler happy.
     9
     10        * bytecode/CodeBlock.cpp:
     11        (JSC::CodeBlock::dumpBytecode):
     12        * dfg/DFGSpeculativeJIT32_64.cpp:
     13        (JSC::DFG::SpeculativeJIT::fillJSValue):
     14        * runtime/BasicBlockLocation.cpp:
     15        (JSC::BasicBlockLocation::getExecutedRanges):
     16        * runtime/ControlFlowProfiler.cpp:
     17        (JSC::ControlFlowProfiler::hasBasicBlockAtTextOffsetBeenExecuted):
     18
    1192015-03-10  Yusuke Suzuki  <utatane.tea@gmail.com>
    220
  • trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

    r181213 r181334  
    608608        size_t i = 0;
    609609        do {
    610             const char* sourceCodeRepresentationDescription;
     610            const char* sourceCodeRepresentationDescription = nullptr;
    611611            switch (m_constantsSourceCodeRepresentation[i]) {
    612612            case SourceCodeRepresentation::Double:
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

    r181035 r181334  
    112112        }
    113113        tagGPR = allocate();
    114         uint32_t tag = JSValue::EmptyValueTag;
     114        int32_t tag = JSValue::EmptyValueTag;
    115115        DataFormat fillFormat = DataFormatJS;
    116116        switch (info.registerFormat()) {
  • trunk/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp

    r180518 r181334  
    5555    while (gaps.size()) {
    5656        Gap minGap(INT_MAX, 0);
    57         unsigned minIdx = -1;
     57        unsigned minIdx = std::numeric_limits<unsigned>::max();
    5858        for (unsigned idx = 0; idx < gaps.size(); idx++) {
    5959            // Because we know that the Gaps inside m_gaps aren't enclosed within one another, it suffices to just check the first element to test ordering.
  • trunk/Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp

    r180518 r181334  
    105105    BasicBlockRange bestRange;
    106106    bestRange.m_startOffset = bestRange.m_endOffset = -1;
     107    bestRange.m_hasExecuted = false; // Suppress MSVC warning.
    107108    // Because some ranges may overlap because of function boundaries, make sure to find the smallest range enclosing the offset.
    108109    for (BasicBlockRange range : blocks) {
  • trunk/Source/WTF/ChangeLog

    r181329 r181334  
     12015-03-10  Mark Lam  <mark.lam@apple.com>
     2
     3        [Win] JSC Build Warnings Need to be Resolved.
     4        <https://webkit.org/b/142366>
     5
     6        Reviewed by Brent Fulgham.
     7
     8        * wtf/Compiler.h:
     9        - MSVC also does not have the CONSIDERS_UNREACHABLE_CODE quirk.
     10
    1112015-03-10  Geoffrey Garen  <ggaren@apple.com>
    212
  • trunk/Source/WTF/wtf/Compiler.h

    r178722 r181334  
    8282#endif
    8383
    84 #if !COMPILER(CLANG)
    85 #define WTF_COMPILER_QUIRK_CONSIDERS_UNREACHABLE_CODE 1
    86 #endif
    87 
    8884#if COMPILER(GCC) && !COMPILER(CLANG) && defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L
    8985#define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT 1
     
    127123#if defined(__SUNPRO_CC) || defined(__SUNPRO_C)
    128124#define WTF_COMPILER_SUNCC 1
     125#endif
     126
     127#if !COMPILER(CLANG) && !COMPILER(MSVC)
     128#define WTF_COMPILER_QUIRK_CONSIDERS_UNREACHABLE_CODE 1
    129129#endif
    130130
Note: See TracChangeset for help on using the changeset viewer.