Changeset 181363 in webkit

Timestamp:

Mar 10, 2015 8:29:44 PM (9 years ago)

Author:

Chris Dumez

Message:

5 tests fail on Apple Mac WK2 performance bots
​https://bugs.webkit.org/show_bug.cgi?id=142485

Reviewed by Andreas Kling.

Only log errors in debug builds if SandboxExtension::createHandle() fails
so that performance tests don't fail because of it. Such error is not
fatal and is expected under certain circumstances. In particular,
SandboxExtension::createHandle() is sometimes called for non-existing
files (e.g. from NetworkResourceLoadParameters::encode()).

• Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandle):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/SandboxExtensionMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-10  Chris Dumez  <cdumez@apple.com>
+
+        5 tests fail on Apple Mac WK2 performance bots
+        https://bugs.webkit.org/show_bug.cgi?id=142485
+
+        Reviewed by Andreas Kling.
+
+        Only log errors in debug builds if SandboxExtension::createHandle() fails
+        so that performance tests don't fail because of it. Such error is not
+        fatal and is expected under certain circumstances. In particular,
+        SandboxExtension::createHandle() is sometimes called for non-existing
+        files (e.g. from NetworkResourceLoadParameters::encode()).
+
+        * Shared/mac/SandboxExtensionMac.mm:
+        (WebKit::SandboxExtension::createHandle):
+
 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm

@@ -221 +221 @@
     handle.m_sandboxExtension = WKSandboxExtensionCreate(standardizedPath.data(), wkSandboxExtensionType(type));
     if (!handle.m_sandboxExtension)
-        WTFLogAlways("Could not create a sandbox extension for '%s'", path.utf8().data());
+        LOG_ERROR("Could not create a sandbox extension for '%s'", path.utf8().data());
 }