Changeset 181930 in webkit

Timestamp:

Mar 24, 2015 9:27:33 PM (9 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: IndexedDB / Databases ContentViews should have refresh button
​https://bugs.webkit.org/show_bug.cgi?id=142996

Reviewed by Timothy Hatcher.

• Localizations/en.lproj/localizedStrings.js:

Remove unused strings.

• UserInterface/Images/ReloadFull.svg: Added.

This is the same as Reload.svg but adjusted to fill the viewbox edge to edge.
The only change is to the viewbox.

• UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.prototype.release):
Some clients would call release not knowing if this was an object or not.
Act gracefully in the case that this was not an object that needs a
remote release.

• UserInterface/Views/DatabaseTableContentView.js:

(WebInspector.DatabaseTableContentView):
(WebInspector.DatabaseTableContentView.prototype.get navigationItems):
(WebInspector.DatabaseTableContentView.prototype._queryError):
(WebInspector.DatabaseTableContentView.prototype._refreshButtonClicked):

• UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._refreshButtonClicked):
Give the storage content views a refresh button to reload the content.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Images/ReloadFull.svg (added)
• UserInterface/Protocol/RemoteObject.js (modified) (1 diff)
• UserInterface/Views/DatabaseTableContentView.js (modified) (3 diffs)
• UserInterface/Views/IndexedDatabaseObjectStoreContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-03-24  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: IndexedDB / Databases ContentViews should have refresh button
+        https://bugs.webkit.org/show_bug.cgi?id=142996
+
+        Reviewed by Timothy Hatcher.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        Remove unused strings.
+
+        * UserInterface/Images/ReloadFull.svg: Added.
+        This is the same as Reload.svg but adjusted to fill the viewbox edge to edge.
+        The only change is to the viewbox.
+
+        * UserInterface/Protocol/RemoteObject.js:
+        (WebInspector.RemoteObject.prototype.release):
+        Some clients would call release not knowing if this was an object or not.
+        Act gracefully in the case that this was not an object that needs a
+        remote release.
+
+        * UserInterface/Views/DatabaseTableContentView.js:
+        (WebInspector.DatabaseTableContentView):
+        (WebInspector.DatabaseTableContentView.prototype.get navigationItems):
+        (WebInspector.DatabaseTableContentView.prototype._queryError):
+        (WebInspector.DatabaseTableContentView.prototype._refreshButtonClicked):
+        * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
+        (WebInspector.IndexedDatabaseObjectStoreContentView):
+        (WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
+        (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
+        (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._refreshButtonClicked):
+        Give the storage content views a refresh button to reload the content.
+
 2015-03-24  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -78 +78 @@
 localizedStrings["Boundary"] = "Boundary";
 localizedStrings["Box Model"] = "Box Model";
-localizedStrings["Breakpoints"] = "Breakpoints";
 localizedStrings["Bubbling"] = "Bubbling";
 localizedStrings["Busy"] = "Busy";
@@ -194 +193 @@
 localizedStrings["Element is the root element"] = "Element is the root element";
 localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
-localizedStrings["Empty Collection"] = "Empty Collection";
 localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
 localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";

trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js

@@ -503 +503 @@
     release: function()
     {
-        RuntimeAgent.releaseObject(this._objectId);
+        if (this._objectId)
+            RuntimeAgent.releaseObject(this._objectId);
     },
 

trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js

@@ -30 +30 @@
     this.element.classList.add(WebInspector.DatabaseTableContentView.StyleClassName);
 
+    var refreshSource, refreshSize;
+    if (WebInspector.Platform.isLegacyMacOS) {
+        refreshSource = "Images/Legacy/Reload.svg";
+        refreshSize = 16;
+    } else {
+        refreshSource = "Images/ReloadFull.svg";
+        refreshSize = 13;
+    }
+
+    this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("database-table-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize);
+    this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this);
+
     this.update();
 };
@@ -37 +49 @@
 WebInspector.DatabaseTableContentView.prototype = {
     constructor: WebInspector.DatabaseTableContentView,
+    __proto__: WebInspector.ContentView.prototype,
 
     // Public
+
+    get navigationItems()
+    {
+        return [this._refreshButtonNavigationItem];
+    },
 
     get allowedNavigationSidebarPanels()
@@ -102 +120 @@
         this.element.removeChildren();
         this.element.appendChild(WebInspector.createMessageTextView(WebInspector.UIString("An error occured trying to\nread the “%s” table.").format(this.representedObject.name), true));
+    },
+
+    _refreshButtonClicked: function()
+    {
+        this.update();
     }
 };
-
-WebInspector.DatabaseTableContentView.prototype.__proto__ = WebInspector.ContentView.prototype;

trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js

@@ -67 +67 @@
 
     this._dataGrid = new WebInspector.DataGrid(columnInfo);
+    this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this));
     this.element.appendChild(this._dataGrid.element);
-
-    this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this));
 
     this._entries = [];
 
     this._fetchMoreData();
+
+    var refreshSource, refreshSize;
+    if (WebInspector.Platform.isLegacyMacOS) {
+        refreshSource = "Images/Legacy/Reload.svg";
+        refreshSize = 16;
+    } else {
+        refreshSource = "Images/ReloadFull.svg";
+        refreshSize = 13;
+    }
+
+    this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("indexed-database-object-store-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize);
+    this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this);
 };
 
@@ -83 +94 @@
 
     // Public
+
+    get navigationItems()
+    {
+        return [this._refreshButtonNavigationItem];
+    },
 
     closed: function()
@@ -149 +165 @@
 
         WebInspector.storageManager.requestIndexedDatabaseData(this._objectStore, this._objectStoreIndex, this._entries.length, 25, processEntries.bind(this));
+    },
+
+    _refreshButtonClicked: function()
+    {
+        this._reset();
+        this._fetchMoreData();
     }
 };