Changeset 182134 in webkit
- Timestamp:
- Mar 30, 2015 12:20:43 AM (9 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r182123 r182134 1 2015-03-30 Benjamin Poulain <benjamin@webkit.org> 2 3 Start the features.json files 4 https://bugs.webkit.org/show_bug.cgi?id=143207 5 6 Reviewed by Darin Adler. 7 8 Start the features.json files to have something to experiment 9 with for the UI. 10 11 * features.json: Added. 12 1 13 2015-03-29 Myles C. Maxfield <mmaxfield@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r182132 r182134 1 2015-03-30 Benjamin Poulain <benjamin@webkit.org> 2 3 Start the features.json files 4 https://bugs.webkit.org/show_bug.cgi?id=143207 5 6 Reviewed by Darin Adler. 7 8 * features.json: Added. 9 1 10 2015-03-29 Simon Fraser <simon.fraser@apple.com> 2 11 -
trunk/Tools/ChangeLog
r182119 r182134 1 2015-03-30 Benjamin Poulain <benjamin@webkit.org> 2 3 Start the features.json files 4 https://bugs.webkit.org/show_bug.cgi?id=143207 5 6 Reviewed by Darin Adler. 7 8 I kept the style checking light. We'll have to figure 9 what is the best format for each field. 10 11 * Scripts/webkitpy/style/checker.py: 12 (CheckerDispatcher._create_checker): 13 * Scripts/webkitpy/style/checkers/jsonchecker.py: 14 (JSONContributorsChecker.check): 15 (JSONFeaturesChecker): 16 (JSONFeaturesChecker.check): 17 1 18 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr> 2 19 -
trunk/Tools/Scripts/webkitpy/style/checker.py
r180224 r182134 46 46 from checkers.jsonchecker import JSONChecker 47 47 from checkers.jsonchecker import JSONContributorsChecker 48 from checkers.jsonchecker import JSONFeaturesChecker 48 49 from checkers.messagesin import MessagesInChecker 49 50 from checkers.png import PNGChecker … … 620 621 if commit_queue and basename == 'contributors.json': 621 622 checker = JSONContributorsChecker(file_path, handle_style_error) 623 if basename == 'features.json': 624 checker = JSONFeaturesChecker(file_path, handle_style_error) 622 625 else: 623 626 checker = JSONChecker(file_path, handle_style_error) -
trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
r160083 r182134 56 56 super(JSONContributorsChecker, self).check(lines) 57 57 self._handle_style_error(0, 'json/syntax', 5, 'contributors.json should not be modified through the commit queue') 58 59 60 class JSONFeaturesChecker(JSONChecker): 61 """Processes the features.json lines""" 62 63 def check(self, lines): 64 super(JSONFeaturesChecker, self).check(lines) 65 66 try: 67 features_definition = json.loads('\n'.join(lines) + '\n') 68 if 'features' not in features_definition: 69 self._handle_style_error(0, 'json/syntax', 5, '"features" key not found, the key is mandatory.') 70 return 71 72 features_list = features_definition['features'] 73 for i in xrange(len(features_list)): 74 feature = features_list[i] 75 if 'name' not in feature: 76 self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "name".' % i) 77 if 'status' not in feature: 78 self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "status".' % i) 79 except: 80 pass
Note: See TracChangeset
for help on using the changeset viewer.