Changeset 182137 in webkit

Timestamp:

Mar 30, 2015 5:41:02 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore:
Add support for deleting emoji on GTK
​https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

The code for deleting special group of characters was specific for
COCOA and EFL platforms. The fix consists on add GTK to the #if
preprocessor directive.

• rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:
Update expectations for delete-emoji test since the bug is fixed now.
​https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderText.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
+
+        Update expectations for delete-emoji test since the bug is fixed now.
+        https://bugs.webkit.org/show_bug.cgi?id=141419
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * platform/gtk/TestExpectations:
+
 2015-03-29  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -541 +541 @@
 
 webkit.org/b/141423 css3/calc/line-height.html [ Failure ]
-webkit.org/b/141419 editing/deleting/delete-emoji.html [ Failure ]
 webkit.org/b/141423 editing/pasteboard/simplfiying-markup-should-not-strip-content.html [ Failure ]
 webkit.org/b/141423 fast/css/font-shorthand-from-longhands.html [ Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
+
+        Add support for deleting emoji on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=141419
+
+        Reviewed by Gustavo Noronha Silva.
+
+        The code for deleting special group of characters was specific for
+        COCOA and EFL platforms. The fix consists on add GTK to the #if
+        preprocessor directive.
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::previousOffsetForBackwardDeletion):
+
 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/rendering/RenderText.cpp

@@ -1402 +1402 @@
 }
 
-#if PLATFORM(COCOA) || PLATFORM(EFL)
+#if PLATFORM(COCOA) || PLATFORM(EFL) || PLATFORM(GTK)
 
 #define HANGUL_CHOSEONG_START (0x1100)
@@ -1444 +1444 @@
 int RenderText::previousOffsetForBackwardDeletion(int current) const
 {
-#if PLATFORM(COCOA) || PLATFORM(EFL)
+#if PLATFORM(COCOA) || PLATFORM(EFL) || PLATFORM(GTK)
     ASSERT(m_text);
     StringImpl& text = *m_text.impl();