Changeset 182481 in webkit

Timestamp:

Apr 7, 2015 11:06:54 AM (9 years ago)

Author:

Brent Fulgham

Message:

[Win] Bots complain about missing /etc/catalog
​https://bugs.webkit.org/show_bug.cgi?id=143484

Reviewed by Chris Dumez.

The libxml2 build on Mac, iOS, and Windows does not provide the set
of default catalog files. We do not actually need these for our
purposes, but we get warnings and some bot flakiness because they
are not present.

We can avoid both problems the same way the Mac and iOS ports do,
by setting the XML_CATALOG_FILES environment variable to 'empty string',
which avoid the warnings and bot problems.

• Scripts/webkitpy/port/win.py:

(WinPort.setup_environ_for_server): Added.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/win.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-04-07  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] Bots complain about missing /etc/catalog
+        https://bugs.webkit.org/show_bug.cgi?id=143484
+
+        Reviewed by Chris Dumez.
+
+        The libxml2 build on Mac, iOS, and Windows does not provide the set
+        of default catalog files. We do not actually need these for our
+        purposes, but we get warnings and some bot flakiness because they
+        are not present.
+
+        We can avoid both problems the same way the Mac and iOS ports do,
+        by setting the XML_CATALOG_FILES environment variable to 'empty string',
+        which avoid the warnings and bot problems.
+
+        * Scripts/webkitpy/port/win.py:
+        (WinPort.setup_environ_for_server): Added.
+
 2015-04-06  Sam Weinig  <sam@webkit.org>
 

trunk/Tools/Scripts/webkitpy/port/win.py

@@ -1 +1 @@
 # Copyright (C) 2010 Google Inc. All rights reserved.
-# Copyright (C) 2013 Apple Inc. All rights reserved.
+# Copyright (C) 2013, 2015 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -91 +91 @@
         return map(self._webkit_baseline_path, fallback_names)
 
+    def setup_environ_for_server(self, server_name=None):
+        env = super(WinPort, self).setup_environ_for_server(server_name)
+        env['XML_CATALOG_FILES'] = ''  # work around missing /etc/catalog <rdar://problem/4292995>
+        return env
+
     def operating_system(self):
         return 'win'