Changeset 182632 in webkit

Timestamp:

Apr 10, 2015 11:07:05 AM (9 years ago)

Author:

peavo@outlook.com

Message:

[Win] Implement some methods in DOMHTMLDocument interface.
​https://bugs.webkit.org/show_bug.cgi?id=143602

Reviewed by Alex Christensen.

• DOMHTMLClasses.cpp:

(DOMHTMLDocument::open):
(DOMHTMLDocument::close):
(DOMHTMLDocument::write):
(DOMHTMLDocument::writeln):

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• DOMHTMLClasses.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2015-04-10  Per Arne Vollan  <peavo@outlook.com>
+
+        [Win] Implement some methods in DOMHTMLDocument interface.
+        https://bugs.webkit.org/show_bug.cgi?id=143602
+
+        Reviewed by Alex Christensen.
+
+        * DOMHTMLClasses.cpp:
+        (DOMHTMLDocument::open):
+        (DOMHTMLDocument::close):
+        (DOMHTMLDocument::write):
+        (DOMHTMLDocument::writeln):
+
 2015-04-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/win/DOMHTMLClasses.cpp

@@ -333 +333 @@
 HRESULT STDMETHODCALLTYPE DOMHTMLDocument::open( void)
 {
-    ASSERT_NOT_REACHED();
-    return E_NOTIMPL;
+    if (!m_document)
+        return E_FAIL;
+
+    m_document->open();
+    return S_OK;
 }
     
 HRESULT STDMETHODCALLTYPE DOMHTMLDocument::close( void)
 {
-    ASSERT_NOT_REACHED();
-    return E_NOTIMPL;
-}
-    
-HRESULT STDMETHODCALLTYPE DOMHTMLDocument::write( 
-        /* [in] */ BSTR /*text*/)
-{
-    ASSERT_NOT_REACHED();
-    return E_NOTIMPL;
-}
-    
-HRESULT STDMETHODCALLTYPE DOMHTMLDocument::writeln( 
-        /* [in] */ BSTR /*text*/)
-{
-    ASSERT_NOT_REACHED();
-    return E_NOTIMPL;
+    if (!m_document)
+        return E_FAIL;
+
+    m_document->close();
+    return S_OK;
+}
+    
+HRESULT STDMETHODCALLTYPE DOMHTMLDocument::write(/* [in] */ BSTR text)
+{
+    if (!m_document)
+        return E_FAIL;
+
+    String string(text);
+    m_document->write(string);
+    return S_OK;
+}
+    
+HRESULT STDMETHODCALLTYPE DOMHTMLDocument::writeln(/* [in] */ BSTR text)
+{
+    if (!m_document)
+        return E_FAIL;
+
+    String string(text);
+    m_document->writeln(string);
+    return S_OK;
 }