Changeset 182647 in webkit

Timestamp:

Apr 10, 2015 6:00:07 PM (9 years ago)

Author:

Yusuke Suzuki

Message:

ES6: Iterator toString names should be consistent
​https://bugs.webkit.org/show_bug.cgi?id=142424

Reviewed by Geoffrey Garen.

Iterator Object Names in the spec right now have spaces.
In our implementation some do and some don't.
This patch aligns JSC to the spec.

• runtime/JSArrayIterator.cpp:
• runtime/JSStringIterator.cpp:
• tests/stress/iterator-names.js: Added.

(test):
(iter):
(check):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSArrayIterator.cpp (modified) (1 diff)
• runtime/JSStringIterator.cpp (modified) (1 diff)
• tests/stress/iterator-names.js (added)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-04-10  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        ES6: Iterator toString names should be consistent
+        https://bugs.webkit.org/show_bug.cgi?id=142424
+
+        Reviewed by Geoffrey Garen.
+
+        Iterator Object Names in the spec right now have spaces.
+        In our implementation some do and some don't.
+        This patch aligns JSC to the spec.
+
+        * runtime/JSArrayIterator.cpp:
+        * runtime/JSStringIterator.cpp:
+        * tests/stress/iterator-names.js: Added.
+        (test):
+        (iter):
+        (check):
+
 2015-04-10  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSArrayIterator.cpp

@@ -34 +34 @@
 namespace JSC {
 
-const ClassInfo JSArrayIterator::s_info = { "ArrayIterator", &Base::s_info, 0, CREATE_METHOD_TABLE(JSArrayIterator) };
+const ClassInfo JSArrayIterator::s_info = { "Array Iterator", &Base::s_info, 0, CREATE_METHOD_TABLE(JSArrayIterator) };
 
 void JSArrayIterator::finishCreation(VM& vm, JSGlobalObject*, ArrayIterationKind kind, JSObject* iteratedObject)

trunk/Source/JavaScriptCore/runtime/JSStringIterator.cpp

@@ -33 +33 @@
 namespace JSC {
 
-const ClassInfo JSStringIterator::s_info = { "StringIterator", &Base::s_info, 0, CREATE_METHOD_TABLE(JSStringIterator) };
+const ClassInfo JSStringIterator::s_info = { "String Iterator", &Base::s_info, 0, CREATE_METHOD_TABLE(JSStringIterator) };
 
 void JSStringIterator::finishCreation(VM& vm, JSGlobalObject*, JSString* iteratedString)