Changeset 182653 in webkit

Timestamp:

Apr 11, 2015 3:02:09 AM (9 years ago)

Author:

Yusuke Suzuki

Message:

[ES6] Enable Symbol in web pages
​https://bugs.webkit.org/show_bug.cgi?id=143375

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Expose Symbol to web pages.
Symbol was exposed, but it was hidden since it breaks Facebook comments.
This is because at that time Symbol is implemented,
but methods for Symbol.iterator and Object.getOwnPropertySymbols are not implemented yet
and it breaks React.js and immutable.js.

Now methods for Symbol.iterator and Object.getOwnPropertySymbols are implemented
and make sure that Facebook comment input functionality is not broken with exposed Symbol.

So this patch replaces runtime flags SymbolEnabled to SymbolDisabled
and makes enabling symbols by default.

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

• runtime/CommonIdentifiers.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

• runtime/RuntimeFlags.h:

Source/WebCore:

• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):

Source/WebKit/mac:

• WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

• Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/ArrayPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/CommonIdentifiers.h (modified) (2 diffs)
• JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ObjectConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/RuntimeFlags.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorFrontendClientLocal.cpp (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebPreferencesPrivate.h (modified) (1 diff)
• WebKit/win/ChangeLog (modified) (1 diff)
• WebKit/win/Interfaces/IWebPreferencesPrivate.idl (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (modified) (1 diff)
• WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (modified) (1 diff)
• WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp (modified) (1 diff)
• WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (modified) (1 diff)
• WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ES6] Enable Symbol in web pages
+        https://bugs.webkit.org/show_bug.cgi?id=143375
+
+        Reviewed by Ryosuke Niwa.
+
+        Expose Symbol to web pages.
+        Symbol was exposed, but it was hidden since it breaks Facebook comments.
+        This is because at that time Symbol is implemented,
+        but methods for Symbol.iterator and Object.getOwnPropertySymbols are not implemented yet
+        and it breaks React.js and immutable.js.
+
+        Now methods for Symbol.iterator and Object.getOwnPropertySymbols are implemented
+        and make sure that Facebook comment input functionality is not broken with exposed Symbol.
+
+        So this patch replaces runtime flags SymbolEnabled to SymbolDisabled
+        and makes enabling symbols by default.
+
+        * runtime/ArrayPrototype.cpp:
+        (JSC::ArrayPrototype::finishCreation):
+        * runtime/CommonIdentifiers.h:
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::init):
+        * runtime/ObjectConstructor.cpp:
+        (JSC::ObjectConstructor::finishCreation):
+        * runtime/RuntimeFlags.h:
+
 2015-04-10  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp

@@ -143 +143 @@
     JSC_NATIVE_FUNCTION(vm.propertyNames->iteratorSymbol, arrayProtoFuncValues, DontEnum, 0);
 
-    if (globalObject->runtimeFlags().isSymbolEnabled()) {
+    if (!globalObject->runtimeFlags().isSymbolDisabled()) {
         JSObject* unscopables = constructEmptyObject(globalObject->globalExec(), globalObject->nullPrototypeObjectStructure());
         const char* unscopableNames[] = {

trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -224 +224 @@
     macro(yield)
 
-#define JSC_COMMON_PRIVATE_IDENTIFIERS_EACH_WELL_KNOWN_SYMBOL(macro) \
+#define JSC_COMMON_PRIVATE_IDENTIFIERS_EACH_WELL_KNOWN_SYMBOL_NOT_IMPLEMENTED_YET(macro)\
     macro(hasInstance) \
     macro(isConcatSpreadable) \
-    macro(iterator) \
     macro(match) \
     macro(replace) \
@@ -234 +233 @@
     macro(split) \
     macro(toPrimitive) \
-    macro(toStringTag) \
+    macro(toStringTag)
+
+#define JSC_COMMON_PRIVATE_IDENTIFIERS_EACH_WELL_KNOWN_SYMBOL(macro) \
+    macro(iterator) \
     macro(unscopables)
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -384 +384 @@
     FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR(PUT_CONSTRUCTOR_FOR_SIMPLE_TYPE)
 
-    if (m_runtimeFlags.isSymbolEnabled())
+    if (!m_runtimeFlags.isSymbolDisabled())
         putDirectWithoutTransition(vm, vm.propertyNames->Symbol, symbolConstructor, DontEnum);
 

trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp

@@ -95 +95 @@
     putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum | DontDelete);
 
-    if (globalObject->runtimeFlags().isSymbolEnabled())
+    if (!globalObject->runtimeFlags().isSymbolDisabled())
         JSC_NATIVE_FUNCTION("getOwnPropertySymbols", objectConstructorGetOwnPropertySymbols, DontEnum, 1);
 }

trunk/Source/JavaScriptCore/runtime/RuntimeFlags.h

@@ -33 +33 @@
 // macro(name, isEnabledFlag)
 #define JSC_RUNTIME_FLAG(macro) \
-    macro(SymbolEnabled, true)\
+    macro(SymbolDisabled, false)\
     macro(PromiseDisabled, false)
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ES6] Enable Symbol in web pages
+        https://bugs.webkit.org/show_bug.cgi?id=143375
+
+        Reviewed by Ryosuke Niwa.
+
+        * inspector/InspectorFrontendClientLocal.cpp:
+        (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
+
 2015-04-10  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp

@@ -122 +122 @@
     m_frontendPage->settings().setAllowFileAccessFromFileURLs(true);
     m_frontendPage->settings().setJavaScriptRuntimeFlags({
-        JSC::RuntimeFlags::SymbolEnabled
     });
     m_dispatchTask = std::make_unique<InspectorBackendDispatchTask>(inspectorController);

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ES6] Enable Symbol in web pages
+        https://bugs.webkit.org/show_bug.cgi?id=143375
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebView/WebPreferencesPrivate.h:
+
 2015-04-08  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h

@@ -54 +54 @@
 
 typedef enum {
-    WebKitJavaScriptRuntimeFlagsSymbolEnabled = 1u << 0,
+    WebKitJavaScriptRuntimeFlagsSymbolDisabled = 1u << 0,
     WebKitJavaScriptRuntimeFlagsPromiseDisabled = 1u << 1,
-    WebKitJavaScriptRuntimeFlagsAllEnabled = WebKitJavaScriptRuntimeFlagsSymbolEnabled
+    WebKitJavaScriptRuntimeFlagsAllEnabled = 0
 } WebKitJavaScriptRuntimeFlags;
 

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ES6] Enable Symbol in web pages
+        https://bugs.webkit.org/show_bug.cgi?id=143375
+
+        Reviewed by Ryosuke Niwa.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+
 2015-04-10  Per Arne Vollan  <peavo@outlook.com>
 

trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl

@@ -33 +33 @@
 
 typedef enum WebKitJavaScriptRuntimeFlags {
-    WebKitJavaScriptRuntimeFlagsSymbolEnabled = 1,  // 1u << 0
+    WebKitJavaScriptRuntimeFlagsSymbolDisabled = 1,  // 1u << 0
     WebKitJavaScriptRuntimeFlagsPromiseDisabled = 2,  // 1u << 1
-    WebKitJavaScriptRuntimeFlagsAllEnabled = WebKitJavaScriptRuntimeFlagsSymbolEnabled
+    WebKitJavaScriptRuntimeFlagsAllEnabled = 0
 } WebKitJavaScriptRuntimeFlags;
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ES6] Enable Symbol in web pages
+        https://bugs.webkit.org/show_bug.cgi?id=143375
+
+        Reviewed by Ryosuke Niwa.
+
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+        * UIProcess/efl/WebInspectorProxyEfl.cpp:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+
 2015-04-08  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h

@@ -51 +51 @@
 
 enum WKJavaScriptRuntimeFlags {
-    kWKJavaScriptRuntimeFlagsSymbolEnabled = 1 << 0,
+    kWKJavaScriptRuntimeFlagsSymbolDisabled = 1 << 0,
     kWKJavaScriptRuntimeFlagsPromiseDisabled = 1 << 1,
-    kWKJavaScriptRuntimeFlagsAllEnabled = kWKJavaScriptRuntimeFlagsSymbolEnabled
+    kWKJavaScriptRuntimeFlagsAllEnabled = 0
 };
 typedef unsigned WKJavaScriptRuntimeFlagSet;

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h

@@ -44 +44 @@
 
 typedef NS_OPTIONS(NSUInteger, _WKJavaScriptRuntimeFlags) {
-    _WKJavaScriptRuntimeFlagsSymbolEnabled = 1 << 0,
+    _WKJavaScriptRuntimeFlagsSymbolDisabled = 1 << 0,
     _WKJavaScriptRuntimeFlagsPromiseDisabled = 1 << 1,
-    _WKJavaScriptRuntimeFlagsAllEnabled = _WKJavaScriptRuntimeFlagsSymbolEnabled
+    _WKJavaScriptRuntimeFlagsAllEnabled = 0
 } WK_ENUM_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
 

trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp

@@ -115 +115 @@
     WKPreferencesRef wkPreferences = WKPageGroupGetPreferences(wkPageGroup);
     WKPreferencesSetFileAccessFromFileURLsAllowed(wkPreferences, true);
-    WKPreferencesSetJavaScriptRuntimeFlags(wkPreferences, kWKJavaScriptRuntimeFlagsSymbolEnabled);
+    WKPreferencesSetJavaScriptRuntimeFlags(wkPreferences, 0);
 
     return toImpl(WKViewGetPage(wkView));

trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp

@@ -71 +71 @@
     preferences->setAllowFileAccessFromFileURLs(true);
     preferences->setJavaScriptRuntimeFlags({
-        JSC::RuntimeFlags::SymbolEnabled
     });
     RefPtr<WebPageGroup> pageGroup = WebPageGroup::create(inspectorPageGroupIdentifier(), false, false);

trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm

@@ -502 +502 @@
 #endif
     preferences._allowFileAccessFromFileURLs = YES;
-    preferences._javaScriptRuntimeFlags = _WKJavaScriptRuntimeFlagsSymbolEnabled;
+    preferences._javaScriptRuntimeFlags = 0;
     [configuration setProcessPool: ::WebKit::wrapper(inspectorProcessPool())];
     [configuration _setGroupIdentifier:inspectorPageGroupIdentifier()];