Changeset 182672 in webkit


Ignore:
Timestamp:
Apr 12, 2015 1:18:01 PM (9 years ago)
Author:
Simon Fraser
Message:

Selects don't scroll at some aspect ratios
https://bugs.webkit.org/show_bug.cgi?id=143649
rdar://problem/19365694

Reviewed by Darin Adler.
Source/WebCore:

Fix width/height flip in RenderListBox which caused us to fail to scroll when
the list was wider than the scroll height.

We're generally confused about RenderListBox scroll offsets (webkit.org/b/143648)
but this fixes the immediate problem.

Test: fast/forms/listbox-visible-size.html

  • rendering/RenderListBox.h:

LayoutTests:

  • fast/forms/listbox-visible-size-expected.txt: Added.
  • fast/forms/listbox-visible-size.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r182669 r182672  
     12015-04-12  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Selects don't scroll at some aspect ratios
     4        https://bugs.webkit.org/show_bug.cgi?id=143649
     5        rdar://problem/19365694
     6
     7        Reviewed by Darin Adler.
     8
     9        * fast/forms/listbox-visible-size-expected.txt: Added.
     10        * fast/forms/listbox-visible-size.html: Added.
     11
    1122015-04-12  Simon Fraser  <simon.fraser@apple.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r182669 r182672  
     12015-04-12  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Selects don't scroll at some aspect ratios
     4        https://bugs.webkit.org/show_bug.cgi?id=143649
     5        rdar://problem/19365694
     6
     7        Reviewed by Darin Adler.
     8       
     9        Fix width/height flip in RenderListBox which caused us to fail to scroll when
     10        the list was wider than the scroll height.
     11       
     12        We're generally confused about RenderListBox scroll offsets (webkit.org/b/143648)
     13        but this fixes the immediate problem.
     14
     15        Test: fast/forms/listbox-visible-size.html
     16
     17        * rendering/RenderListBox.h:
     18
    1192015-04-12  Simon Fraser  <simon.fraser@apple.com>
    220
  • trunk/Source/WebCore/rendering/RenderListBox.h

    r182127 r182672  
    124124    virtual Scrollbar* verticalScrollbar() const override { return m_vBar.get(); }
    125125    virtual IntSize contentsSize() const override;
    126     virtual IntSize visibleSize() const override { return IntSize(height(), width()); }
     126    virtual IntSize visibleSize() const override { return IntSize(width(), height()); }
    127127    virtual IntPoint lastKnownMousePosition() const override;
    128128    virtual bool isHandlingWheelEvent() const override;
Note: See TracChangeset for help on using the changeset viewer.