Changeset 18288 in webkit

Timestamp:

Dec 18, 2006 3:22:20 PM (17 years ago)

Author:

bdash

Message:

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Changed hidden input controls to reset to their initial values
when the form is reset. Also added layout tests for resetting
other input controls.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11866

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11866

• fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
• fast/dom/HTMLInputElement/input-checked-reset.html: Added.
• fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
• fast/dom/HTMLInputElement/input-text-reset.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLInputElement/input-checked-reset-expected.txt (added)
• LayoutTests/fast/dom/HTMLInputElement/input-checked-reset.html (added)
• LayoutTests/fast/dom/HTMLInputElement/input-text-reset-expected.txt (added)
• LayoutTests/fast/dom/HTMLInputElement/input-text-reset.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-12-18  Kirby White  <KWhiteRight@gmail.com>
+
+        Reviewed by Darin.
+
+        Layout tests for http://bugs.webkit.org/show_bug.cgi?id=11866
+
+        * fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
+        * fast/dom/HTMLInputElement/input-checked-reset.html: Added.
+        * fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
+        * fast/dom/HTMLInputElement/input-text-reset.html: Added.
+
 2006-12-18  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-12-18  Kirby White  <KWhiteRight@gmail.com>
+
+        Reviewed by Darin.
+
+        Changed hidden input controls to reset to their initial values
+        when the form is reset.  Also added layout tests for resetting
+        other input controls.
+
+        Fixes http://bugs.webkit.org/show_bug.cgi?id=11866
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValue):
+        (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
+
 2006-12-18  Alice Liu  <alice.liu@apple.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -1071 +1071 @@
         if (renderer())
             renderer()->updateFromElement();
-        setChanged();
+        // Changes to hidden values don't require re-rendering.
+        if (m_type != HIDDEN)
+            setChanged();
     } else
         setAttribute(valueAttr, constrainValue(value));
@@ -1108 +1110 @@
         case CHECKBOX:
         case FILE:
-        case HIDDEN:
         case IMAGE:
         case RADIO:
@@ -1115 +1116 @@
         case SUBMIT:
             return false;
+        case HIDDEN:
         case ISINDEX:
         case PASSWORD: