Changeset 182960 in webkit

Timestamp:

Apr 17, 2015 12:08:11 PM (9 years ago)

Author:

ap@apple.com

Message:

build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
​https://bugs.webkit.org/show_bug.cgi?id=143885

Reviewed by Tim Horton.

Fixed a case where we have two builds with the same revision(s). An in order build
is one for which the revision is strictly higher.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype._checkForInOrderResult):
(BuildbotQueue.prototype.compareIterationsByRevisions):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js

@@ -238 +238 @@
             var i1 = iterationsInOriginalOrder[i];
             var i2 = iterationsInOriginalOrder[i + 1];
-            if (i1.productive && i2.loaded && this.compareIterations(i1, i2) < 0) {
+            if (i1.productive && i2.loaded && this.compareIterationsByRevisions(i1, i2) < 0) {
                 this._hasLoadedIterationForInOrderResult = true;
                 return;
@@ -283 +283 @@
     },
 
+    compareIterationsByRevisions: function(a, b)
+    {
+        var result = b.openSourceRevision - a.openSourceRevision;
+        if (result)
+            return result;
+
+        result = b.internalRevision - a.internalRevision;
+        if (result)
+            return result;
+
+        return 0;
+    },
+
     sortIterations: function()
     {

trunk/Tools/ChangeLog

@@ +1 @@
+2015-04-17  Alexey Proskuryakov  <ap@apple.com>
+
+        build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
+        https://bugs.webkit.org/show_bug.cgi?id=143885
+
+        Reviewed by Tim Horton.
+
+        Fixed a case where we have two builds with the same revision(s). An in order build
+        is one for which the revision is strictly higher.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+        (BuildbotQueue.prototype._checkForInOrderResult):
+        (BuildbotQueue.prototype.compareIterationsByRevisions):
+
 2015-04-17  Commit Queue  <commit-queue@webkit.org>