Changeset 183431 in webkit

Timestamp:

Apr 27, 2015 3:24:07 PM (9 years ago)

Author:

jer.noble@apple.com

Message:

[iOS] Video not centered in element on retina devices
​https://bugs.webkit.org/show_bug.cgi?id=144274

Reviewed by Simon Fraser.

In r173702, a transform was added to the video layer (and a matching, inverse transform
in the UIProcess), but this transform affects the position property of the video layer
used to position the video content within the element bounds when their aspect ratios
do not match.

To work around this problem, pre-apply the transform during -setPosition:.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebVideoContainerLayer setPosition:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-27  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] Video not centered in element on retina devices
+        https://bugs.webkit.org/show_bug.cgi?id=144274
+
+        Reviewed by Simon Fraser.
+
+        In r173702, a transform was added to the video layer (and a matching, inverse transform
+        in the UIProcess), but this transform affects the position property of the video layer
+        used to position the video content within the element bounds when their aspect ratios
+        do not match.
+
+        To work around this problem, pre-apply the transform during -setPosition:.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (-[WebVideoContainerLayer setPosition:]):
+
 2015-04-27  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -116 +116 @@
         layer.frame = bounds;
 }
+
+- (void)setPosition:(CGPoint)position
+{
+    if (!CATransform3DIsIdentity(self.transform)) {
+        // Pre-apply the transform added in the WebProcess to fix <rdar://problem/18316542> to the position.
+        position = CGPointApplyAffineTransform(position, CATransform3DGetAffineTransform(self.transform));
+    }
+    [super setPosition:position];
+}
 @end